Skip to content

fix(webp): Missing oiio:UnassociatedAlpha on input#5020

Merged
lgritz merged 1 commit into
AcademySoftwareFoundation:mainfrom
brechtvl:fix-webp-unassociated-alpha
Jan 29, 2026
Merged

fix(webp): Missing oiio:UnassociatedAlpha on input#5020
lgritz merged 1 commit into
AcademySoftwareFoundation:mainfrom
brechtvl:fix-webp-unassociated-alpha

Conversation

@brechtvl
Copy link
Copy Markdown
Contributor

@brechtvl brechtvl commented Jan 29, 2026

Description

Like other file formats, the returned ImageSpec should indicate if the image contains unassociated alpha.

This was an oversight in #4770.

Tests

Test added.

Checklist:

  • I have read the guidelines on contributions and code review procedures.
  • I have updated the documentation if my PR adds features or changes
    behavior.
  • I am sure that this PR's changes are tested somewhere in the
    testsuite
    .
  • I have run and passed the testsuite in CI before submitting the
    PR, by pushing the changes to my fork and seeing that the automated CI
    passed there. (Exceptions: If most tests pass and you can't figure out why
    the remaining ones fail, it's ok to submit the PR and ask for help. Or if
    any failures seem entirely unrelated to your change; sometimes things break
    on the GitHub runners.)
  • My code follows the prevailing code style of this project and I
    fixed any problems reported by the clang-format CI test.
  • If I added or modified a public C++ API call, I have also amended the
    corresponding Python bindings. If altering ImageBufAlgo functions, I also
    exposed the new functionality as oiiotool options.

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
@brechtvl
Copy link
Copy Markdown
Contributor Author

FYI @jessey-git

Copy link
Copy Markdown
Contributor

@jessey-git jessey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, seems like I missed this :-/

Looks good to me and thanks for adding that test.

@lgritz lgritz merged commit fb8cde9 into AcademySoftwareFoundation:main Jan 29, 2026
28 of 30 checks passed
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Jan 30, 2026
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Feb 24, 2026
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 1, 2026
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad <shaamaan@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 2, 2026
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 2, 2026
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 2, 2026
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>
ssh4net pushed a commit to ssh4net/OpenImageIO that referenced this pull request Apr 2, 2026
…undation#5020)

Like other file formats, the returned ImageSpec should indicate if the
image contains unassociated alpha.

This was an oversight in AcademySoftwareFoundation#4770.

Test added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants