fmath.h: re-inline convert_type() half varieties#5130
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
fmath.h: re-inline convert_type() half varieties#5130lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
A few years ago, in PR 3301, we made a big effort to remove Imath types as much as possible from the public APIs. Somehow, as part of that refactor, we ended up with just the half-varieties of fmath.h's convert_types() templates actually being implemented in fmath.cpp and only declared (by default) in fmath.h. I'm honestly not sure why I did that now, and the PR doesn't explain that particular point. But that sets up a potential link incompatibility if OIIO used a different release of Imath than the use is using when calling that utility function. So this PR makes it fully inline again, so the Imath version the downstream package uses just doesn't need to match what was found/used at the time that OIIO was build. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few years ago, in PR #3301, we made a big effort to remove Imath types as much as possible from the public APIs. Somehow, as part of that refactor, we ended up with just the half-varieties of fmath.h's convert_types() templates actually being implemented in fmath.cpp and only declared (by default) in fmath.h. I'm honestly not sure why I did that now, and the PR doesn't explain that particular point.
But that sets up a potential link incompatibility if OIIO used a different release of Imath than the use is using when calling that utility function.
So this PR makes it fully inline again, so the Imath version the downstream package uses just doesn't need to match what was found/used at the time that OIIO was built.