perf: Speedup other file ops on Windows#5199
Conversation
Signed-off-by: Lumina Wang <lumina.wang@autodesk.com>
|
Can I ask a naive question? Is the implementation of these std::filesystem functions on Windows not equivalent to what you wrote? Why are they so slow in the std library as provided by MSVS? |
Functionally these changes can achieve what we expect from |
|
The CI failure appears unrelated, I will merge as soon as the Windows job completes. |
9968f8c
into
AcademySoftwareFoundation:main
…eFoundation#5199) Similar to AcademySoftwareFoundation#4977, replace `std::filesystem` with Windows APIs for better performance. Signed-off-by: Lumina Wang <lumina.wang@autodesk.com>
…eFoundation#5199) Similar to AcademySoftwareFoundation#4977, replace `std::filesystem` with Windows APIs for better performance. Signed-off-by: Lumina Wang <lumina.wang@autodesk.com>
Description
Similar to #4977, replace
std::filesystemwith Windows APIs for better performance.Tests
No new test.
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.