int(webp, jpeg-xl): Added check_open for WebP and JPEG XL readers#5202
Merged
lgritz merged 1 commit intoMay 16, 2026
Merged
Conversation
Signed-off-by: Hannah Gulka <hannahkg8@gmail.com>
|
|
Collaborator
|
The failure for the "VFX2023" test is unrelated to your PR and is being fixed separately. If everything else is ok, we will not hold up the merge just because of that. |
lgritz
approved these changes
May 16, 2026
Collaborator
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the patch
lgritz
merged commit 539aba4
into
AcademySoftwareFoundation:main
28 of 29 checks passed
lgritz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the feature request in issue #3974
Continuing from previous work done on this feature request, I have added
check_opencalls to two new format readers, using file format specs found online:I also cross-referenced this info with the corresponding ImageOutput::check_open calls for sanity, and they seemed to align.
Tests
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.