testing: Add optix ref output for new test added in PR 1991#1996
Merged
Conversation
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
This is great because it highlights the kind of mistake that in theory will be very hard to make now that we have the optix testing in CI! |
Merged
Contributor
|
Strange, because the optix side was passing for me locally. I guess it is an optix version driver thing? Does the reference look right? Otherwise LGTM |
Contributor
|
Just downloaded it, reference looks good. |
aconty
approved these changes
Jun 9, 2025
Collaborator
Author
I assume that locally, your OptiX output matched the CPU output closely enough to pass, but that on the CI runners, differences in hardware, optix version, driver, and who knows what else compared to your workstation happened to make just enough differences to fail the test thresholds. |
lgritz
added
the
build / testing / port / CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1991 (adding conductor BSDF) crossed paths in flight with #1992 (adding full OptiX tests to CI). So the former was merged without the benefit of being confirmed to fully pass on GPU.