testing: Reduce output precision of geomath and trig, collapse variants#2126
Merged
Conversation
Analyzing the geomath and trig testsuite entires, each of them had multiple reference outputs due to small precision differences between platforms and optimization levels. By printing only 4 digits of precision (and in one case of an unstable value to pass to tan, just picking a different value), we are able to collapse those tests to one reference output each. only flushes near-zero values, not precision. With the reduced precision every platform/backend produces identical text, so the four variant references are removed and a single ref/out.txt remains. The JIT and C++ (OSL_DEBUG_OUTPUT_CPP=3) backends now produce byte-identical output and both pass against it. Assisted-by: Claude Code / Claude Opus 4.8 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Any comments? |
fpsunflower
approved these changes
Jun 17, 2026
lgritz
merged commit 45ae428
into
AcademySoftwareFoundation:main
98 of 102 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzing the geomath and trig testsuite entries, each of them had multiple reference outputs due to small precision differences between platforms and optimization levels. By printing only 4 digits of precision (and in one case of an unstable value to pass to tan, just picking a different value), we are able to collapse those tests to one reference output each.
Assisted-by: Claude Code / Claude Opus 4.8