Skip to content

Transitions: Add enabled flag#2022

Open
natchar wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
natchar:otio_transition_enabled
Open

Transitions: Add enabled flag#2022
natchar wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
natchar:otio_transition_enabled

Conversation

@natchar
Copy link
Copy Markdown

@natchar natchar commented May 14, 2026

Fixes #1186

Added Enabled flag to Transitions.
Updated tests/test_transition.py

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.51%. Comparing base (7adfb27) to head (d3e7aa7).

Files with missing lines Patch % Lines
...entimelineio-bindings/otio_serializableObjects.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   84.50%   84.51%           
=======================================
  Files         181      181           
  Lines       13225    13239   +14     
  Branches     1202     1202           
=======================================
+ Hits        11176    11189   +13     
- Misses       1866     1867    +1     
  Partials      183      183           
Flag Coverage Δ
py-unittests 84.51% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentimelineio/transition.cpp 100.00% <100.00%> (ø)
src/opentimelineio/transition.h 100.00% <100.00%> (ø)
...opentimelineio/opentimelineio/schema/transition.py 100.00% <100.00%> (ø)
tests/test_transition.py 95.45% <100.00%> (+0.45%) ⬆️
...entimelineio-bindings/otio_serializableObjects.cpp 83.18% <85.71%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7adfb27...d3e7aa7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Natchar Ratanasirigulchai <natchar.r@outlook.com>
@natchar natchar force-pushed the otio_transition_enabled branch from 231cb70 to d3e7aa7 Compare May 14, 2026 21:53
Copy link
Copy Markdown
Contributor

@timlehr timlehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @natchar! This looks good IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add enabled Flag to Transitions

3 participants