feat: CMake builds with OpenSSL support#373
Conversation
This feature adds OpenSSL support for CMake. Signed-off-by: victorfleury <victor.fleury@gmail.com>
|
You will want to check out this build failure: Normally the Python tests are supposed to run at git commit time, did they not run? Perhaps the switch to uv messed up the pre-commit hooks that are supposed to do that. We can take a look together tomorrow. |
|
It looks like the commit hooks are still working, not sure why they didn't run for you? Perhaps an env var? The tests in |
|
I think it's my bad. |
Signed-off-by: victorfleury <victor.fleury@gmail.com>
Reformatting using `black` Signed-off-by: victorfleury <victor.fleury@gmail.com>
|
The build for the In This workflow never completes anyway, it will either run our of disk space or time, and needs some more restructuring anyway. So I'll let the branch in as is, and "fix" this workflow later. |
07abcab
into
AcademySoftwareFoundation:main
|
I can make another PR with the changes in As for the build in |
|
I made those changes in my own PR which I've just merged: |
Summary
With this PR we add the
OpenSSLsupport tocmakeso we avoid the following error reported in #326:Steps to test
I have ran the following commands to test that
cmakeis built withopenssland can fetch archives from the web usinghttps://URIsBuilds :
Testing :
I ran the following snippet inside the docker containers (for each version of
ci_common)Placed it in a
/tmp/folder and then rancmakeI got this output :
So I would say this is working but happy to get any feedback and start the ball rolling :)
Thanks @jfpanisset for all the help getting this one out :)