Arcmantis/warning deprecate WidenFilename (#2398)

* Added OPENEXR_DEPRECATED to function WidenFilename indicating its future removal

Signed-off-by: Aries Moczar <arcmantis@protulae.com>

* Disable warnings of deprecated WidenFilename in unit-tests

Signed-off-by: Aries Moczar <arcmantis@protulae.com>

* Corrected compiler check from _WIN32 to _MSC_VER. Added additional conditions for __clang__ and __GNUC__.

Signed-off-by: Aries Moczar <arcmantis@protulae.com>

* Added TODO comments indicating pragmas disabling deprecation-warnings should be removed once WidenFilename is removed.

Signed-off-by: Aries Moczar <arcmantis@protulae.com>

* Tightened pragmas around WidenFilename to be more precise when disabling deprectation warnings

Signed-off-by: Aries Moczar <arcmantis@protulae.com>

---------

Signed-off-by: Aries Moczar <arcmantis@protulae.com>
Co-authored-by: Cary Phillips <cary@ilm.com>

Author: Arcmantis18

src/lib/OpenEXR/ImfMisc.h

@@ -438,6 +438,7 @@ int getChunkOffsetTableSize (const Header& header);
 // Convert a UTF-8 filename to a wide string (for example for Windows APIs).
 //
 
+OPENEXR_DEPRECATED ("To be removed in future releases.")
 IMF_EXPORT
 std::wstring WidenFilename (const char* filename);
 

src/test/OpenEXRTest/TestUtilFStream.h

@@ -103,8 +103,26 @@ inline void
 OpenStreamWithUTF8Name (
     StreamType& is, const char* filename, std::ios_base::openmode mode)
 {
-#    ifdef _WIN32
+
+#   ifdef _WIN32
+
+// TODO: Remove pragmas for pushing/popping deprecation warnings when WidenFilename is removed from API
+#   ifdef _MSC_VER
+#       pragma warning(push)
+#       pragma warning(disable: 4996)
+#   elif defined(__clang__) || defined(__GNUC__)
+#       pragma GCC diagnostic push
+#       pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#   endif
+
     std::wstring wfn = OPENEXR_IMF_INTERNAL_NAMESPACE::WidenFilename (filename);
+
+#   ifdef _MSC_VER
+#       pragma warning(pop)
+#   elif defined(__clang__) || defined(__GNUC__)
+#       pragma GCC diagnostic pop
+#   endif
+
 #        ifdef USE_WIDEN_FILEBUF
     using CharT   = typename StreamType::char_type;
     using TraitsT = typename StreamType::traits_type;

src/test/OpenEXRTest/testExistingStreams.cpp

@@ -127,7 +127,24 @@ MMIFStream::MMIFStream (const char fileName[])
     , _length (0)
 {
 #ifdef _WIN32
+
+    // TODO: Remove pragmas for pushing/popping deprecation warnings when WidenFilename is removed from API
+#   ifdef _MSC_VER
+#       pragma warning(push,0)
+#       pragma warning(disable: 4996)
+#   elif defined(__clang__) || defined(__GNUC__)
+#       pragma GCC diagnostic push
+#       pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#   endif
+
     const std::wstring fileNameWide = WidenFilename (fileName);
+
+#   ifdef _MSC_VER
+#       pragma warning(pop)
+#   elif defined(__clang__) || defined(__GNUC__)
+#       pragma GCC diagnostic pop
+#   endif
+
     try
     {
         _f = CreateFileW (
@@ -1093,7 +1110,23 @@ testExistingStreamsUTF8 (const std::string& tempDir)
     {
         cout << "writing";
 #ifdef _WIN32
+
+    // TODO: Remove pragmas for pushing/popping deprecation warnings when WidenFilename is removed from API
+#   ifdef _MSC_VER
+#       pragma warning(push,0)
+#       pragma warning(disable: 4996)
+#   elif defined(__clang__) || defined(__GNUC__)
+#       pragma GCC diagnostic push
+#       pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#   endif
+
         _wremove (WidenFilename (outfn.c_str ()).c_str ());
+
+#   ifdef _MSC_VER
+#       pragma warning(pop)
+#   elif defined(__clang__) || defined(__GNUC__)
+#       pragma GCC diagnostic pop
+#   endif
 #else
         remove (outfn.c_str ());
 #endif
@@ -1144,7 +1177,23 @@ testExistingStreamsUTF8 (const std::string& tempDir)
     cout << endl;
 
 #ifdef _WIN32
+
+    // TODO: Remove pragmas for pushing/popping deprecation warnings when WidenFilename is removed from API
+#   ifdef _MSC_VER
+#       pragma warning(push,0)
+#       pragma warning(disable: 4996)
+#   elif defined(__clang__) || defined(__GNUC__)
+#       pragma GCC diagnostic push
+#       pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#   endif
+
     _wremove (WidenFilename (outfn.c_str ()).c_str ());
+
+#   ifdef _MSC_VER
+#       pragma warning(pop)
+#   elif defined(__clang__) || defined(__GNUC__)
+#       pragma GCC diagnostic pop
+#   endif
 #else
     remove (outfn.c_str ());
 #endif