Add macOS universal2 build to CI, and bump OpenJPH to 0.21.3#2058
Merged
Conversation
Universal2 builds with CMAKE_OSX_ARCHITECTURES=x8664;arm64. OpenJPH failed with this until 0.21,3 Technically, the cibuildwheel action does this but failure messages there are harder to parse, so better to treat it as a first-class CI check. Signed-off-by: Cary Phillips <cary@ilm.com>
Contributor
|
I think the title of this PR should be changed |
cary-ilm
changed the title
Member
Author
|
Oops, right. |
Member
Author
|
Not the first time I've typed that wrong. |
Member
Author
|
@peterhillman, you OK looking this over? |
peterhillman
approved these changes
Jun 13, 2025
Contributor
peterhillman
left a comment
peterhillman
left a comment
There was a problem hiding this comment.
Looks good to me, though I have little knowledge of macOS universal builds.
Would it be better if the manifest validation ignored the patch version number in filenames, so version bumps can happen without needing to upload new manifests?
Member
Author
|
Maybe, let's discuss the version validation scheme more in a separate issue. It's worth having the system guard against an incorrect version number slipping out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Universal2 builds with CMAKE_OSX_ARCHITECTURES=x8664;arm64.
OpenJPH failed with this until 0.21,3
Technically, the cibuildwheel action does this but failure messages there are harder to parse, so better to treat it as a first-class CI check.