Skip to content

Removes dependency of HTJ2K Compressor on realloc()#2061

Merged
cary-ilm merged 1 commit into
AcademySoftwareFoundation:mainfrom
sandflow:issues/remove-realloc
Jun 26, 2025
Merged

Removes dependency of HTJ2K Compressor on realloc()#2061
cary-ilm merged 1 commit into
AcademySoftwareFoundation:mainfrom
sandflow:issues/remove-realloc

Conversation

@palemieux
Copy link
Copy Markdown
Collaborator

@palemieux palemieux commented Jun 11, 2025

Closes #2060

exrmetrics write time before the patch:

 .\bin\Release\exrmetrics.exe  "C:\Users\pal\scratch\OpenEXR\SPARKS_4K_P3_PQ_4000nits_EXR\500-skip\SPARKS_P3_PQ_4000nit_02500.exr" -z htj2k
    {
      "compression": "htj2k",
      "pixel mode": "original",
      "output size": 25219604,
      "read time": 0.0361311,
      "write time": 4.79588,
      "re-read time": 0.188013
    }

exrmetrics write time after the patch:

 .\bin\Release\exrmetrics.exe  "C:\Users\pal\scratch\OpenEXR\SPARKS_4K_P3_PQ_4000nits_EXR\500-skip\SPARKS_P3_PQ_4000nit_02500.exr" -z htj2k
    {
      "compression": "htj2k",
      "pixel mode": "original",
      "output size": 25219604,
      "read time": 0.0268385,
      "write time": 0.296235,
      "re-read time": 0.169697
    }

@cary-ilm cary-ilm requested review from kdt3rd June 13, 2025 18:18
@cary-ilm
Copy link
Copy Markdown
Member

@kdt3rd, this seems fine to me but can you look this over?

Copy link
Copy Markdown
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks.

@palemieux, can you update the branch?

Signed-off-by: Pierre-Anthony Lemieux <pal@palemieux.com>
@palemieux palemieux force-pushed the issues/remove-realloc branch from 8eb068c to 1103c6d Compare June 19, 2025 20:49
@palemieux
Copy link
Copy Markdown
Collaborator Author

@cary-ilm Done

@cary-ilm cary-ilm merged commit 45ee127 into AcademySoftwareFoundation:main Jun 26, 2025
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Realloc() causes OpenJPH slowdown on Windows OS

2 participants