Correct index rejection for string access.#2392
Merged
cary-ilm merged 1 commit intoApr 30, 2026
Merged
Conversation
… because this would be out-of bounds as arrays are zero-indexed. Addresses issue AcademySoftwareFoundation#2379 Signed-off-by: Aries Moczar <arcmantis@protulae.com>
peterhillman
approved these changes
Apr 29, 2026
Contributor
peterhillman
left a comment
peterhillman
left a comment
There was a problem hiding this comment.
Yes, I think that fixes the problem.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected index verification to reject index matching the string size because this would be out-of bounds as arrays are zero-indexed. Addresses issue #2379