Fix memory leaks#2422
Merged
cary-ilm merged 3 commits intoMay 17, 2026
Merged
Conversation
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
failing to add a part was not reverting cleanly. However, when reverting, the array storing the list of the parts was not being updated correctly, causing more potential memory leaks with lots of failures. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
cary-ilm
pushed a commit
that referenced
this pull request
May 21, 2026
* fix memory leak in test only - invalid api call Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * simplify string init Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * refactor part memory handling for parts failing to add a part was not reverting cleanly. However, when reverting, the array storing the list of the parts was not being updated correctly, causing more potential memory leaks with lots of failures. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> --------- Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
palemieux
pushed a commit
to sandflow/openexr-ht
that referenced
this pull request
Jun 10, 2026
* fix memory leak in test only - invalid api call Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * simplify string init Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * refactor part memory handling for parts failing to add a part was not reverting cleanly. However, when reverting, the array storing the list of the parts was not being updated correctly, causing more potential memory leaks with lots of failures. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> --------- Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> Signed-off-by: Pierre-Anthony Lemieux <pal@sandflow.com>
peterhillman
pushed a commit
that referenced
this pull request
Jun 19, 2026
* fix memory leak in test only - invalid api call Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * simplify string init Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * refactor part memory handling for parts failing to add a part was not reverting cleanly. However, when reverting, the array storing the list of the parts was not being updated correctly, causing more potential memory leaks with lots of failures. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> --------- Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running with address sanitizer, noticed a small duplication of a line triggering a leak in a test.
But more importantly, refactor multi-part part array handling to avoid getting out of sync which can trigger more memory leaks, and properly free the part structure.
Addresses https://issues.oss-fuzz.com/issues/512314697