Fix computation of chunk height#2423
Merged
cary-ilm merged 6 commits intoMay 18, 2026
Merged
Conversation
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
When there are strange y_sampling, the number of lines per chunk was not being computed correctly depending on how the start position lines up with the sampling Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
This was referenced May 17, 2026
cary-ilm
reviewed
May 18, 2026
cary-ilm
reviewed
May 18, 2026
remove debugging printf Signed-off-by: Cary Phillips <cary@ilm.com>
remove debugging printf Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
approved these changes
May 18, 2026
Member
cary-ilm
left a comment
cary-ilm
left a comment
There was a problem hiding this comment.
Thanks! I removed a couple printf's, they appear to just be debugging aids, so better to not clutter the logs permanently.
|
ah, I was doing it at night time, but those versions of the validation functions should only print anything if it failed (as a debugging thing, yes), can probably further clean up if we don't want that... (that's why I called them _p) |
Member
|
Ah, ok, I thought they might clutter the logs. Anyway, looks good, thanks! |
cary-ilm
merged commit 15fa71c
into
AcademySoftwareFoundation:main
52 of 55 checks passed
cary-ilm
added a commit
that referenced
this pull request
May 21, 2026
* remove errant include Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * add test for combo of start line, lines per compression, y samples Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * fix compute of sampled height When there are strange y_sampling, the number of lines per chunk was not being computed correctly depending on how the start position lines up with the sampling Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Apply suggestion from @cary-ilm remove debugging printf Signed-off-by: Cary Phillips <cary@ilm.com> * Apply suggestion from @cary-ilm remove debugging printf Signed-off-by: Cary Phillips <cary@ilm.com> --------- Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> Signed-off-by: Cary Phillips <cary@ilm.com> Co-authored-by: Cary Phillips <cary@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the starting line, the lines per chunk (compression), and the y_sampling, the existing compute height was broken.
Add a test case
Addresses https://issues.oss-fuzz.com/issues/508362159
Addresses https://issues.oss-fuzz.com/issues/507413960