Massive improvements to vdb tool#2241
Conversation
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <kmuseth@nvidia.com>
Signed-off-by: apradhana <andre.pradhana@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
…_point_index_io_bug Fix Point Index I/O Bug
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <kmuseth@nvidia.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
* Bugfix for GridHandle::read(). Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com> * Simplify. Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com> * Adding pendingchanges file. Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com> * Tweak wording. Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com> * Add a test Signed-off-by: Jonathan Swartz <jonathan@jswartz.info> * Requested change. Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com> --------- Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com> Signed-off-by: Jonathan Swartz <jonathan@jswartz.info> Co-authored-by: Jonathan Swartz <jonathan@jswartz.info>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
|
Very high level comment, the design of the kernel and forallvalues (and other iterators) actions looks like it provide a similar interface to what you might do with VDB AX, can you not chain the use of vdb_tool through the vdb_ax cli to provide the same functionality? I can see that some things that are missing in current AX functionality are supported (user-def functions for example) but would love to get efforts towards getting these working in AX instead of making a tool that overlaps in functionality. |
Great observation @richhones, and that has definitely crossed my mind. In fact, that is the goal, but there are two reasons why it shouldn't block this PR. First, this PR is carefully crafted to introduce a lot of new features without any new mandatory dependencies. As you know, AX requires several new dependencies that would have to be made optional for vdb_tool. Second, while this implementation of stream processing does conceptually overlap with AX, it is a lightweight stand-in for fast prototyping. It has no JIT compilation—so it's presumably much slower—and is by no means a replacement for AX. So, yes, I completely agree AX should be integrated into vdb_tool moving forward, but I'm not convinced it should block this already massive PR. However, I'm happy to prioritize AX integration as the next improvement (though the memory management between scoped variables in AX and the vdb_tool will be nontrivial) |
Signed-off-by: Ken Museth <ken.museth@gmail.com>
Signed-off-by: Ken Museth <ken.museth@gmail.com>
1e702c1 to
19cf37b
Compare
Signed-off-by: Ken Museth <ken.museth@gmail.com>
80de1d6 to
cdf3a40
Compare
Signed-off-by: Ken Museth <1495380+kmuseth@users.noreply.github.com>
New Features:
Improvements:
Fixes: