fix: prefer std::filesystem error_code overloads over exceptions#295
Open
hesam-oxe wants to merge 2 commits into
Open
fix: prefer std::filesystem error_code overloads over exceptions#295hesam-oxe wants to merge 2 commits into
hesam-oxe wants to merge 2 commits into
Conversation
Replaced full-table literals with spot-checks for fixtures and fingerprint verification for transforms. Reduced from ~1900 to ~450 lines. Closes AcademySoftwareFoundation#276
Replaced throwing std::filesystem calls with non-throwing error_code overloads in process_image and make_output_path. Closes AcademySoftwareFoundation#275
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced throwing std::filesystem calls with non-throwing error_code
overloads in
process_image()andmake_output_path().Changes
process_image(): Removed try/catch aroundstd::filesystem::exists(),now uses
std::filesystem::exists(path, ec)with explicit error_codehandling
make_output_path(): Updatedexists()andcreate_directory()callsto use error_code overloads
behavior
Why
The C++ standard library allows querying filesystem operations with
error_code instead of exceptions. This avoids exception-based control
flow for expected filesystem failures and is consistent with modern
C++ best practices.
Closes #275