Skip to content

fix: prefer std::filesystem error_code overloads over exceptions #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hesam-oxe wants to merge 2 commits into
base: main
Choose a base branch
from
+185 −5,040
Open

fix: prefer std::filesystem error_code overloads over exceptions #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d366bab
test: slim down testIDT.cpp with spot-checks and fingerprints
hesam-oxe May 10, 2026
69b7063
fix: prefer std::filesystem error_code overloads over exceptions
hesam-oxe Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions src/rawtoaces_util/image_converter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2542,11 +2542,12 @@ bool ImageConverter::make_output_path(

new_directory = old_directory / new_directory;

if ( !std::filesystem::exists( new_directory ) )
std::error_code dir_ec;
if ( !std::filesystem::exists( new_directory, dir_ec ) )
{
if ( settings.create_dirs )
{
if ( settings.create_dirs )
{
if ( !std::filesystem::create_directory( new_directory ) )
if ( !std::filesystem::create_directory( new_directory, dir_ec ) )
{
status = Status::OutputDirectoryError;
last_error_message = "Failed to create directory: '" +
Expand All @@ -2565,7 +2566,7 @@ bool ImageConverter::make_output_path(
temp_path = std::filesystem::absolute( new_directory / filename );
}

if ( !settings.overwrite && std::filesystem::exists( temp_path ) )
if ( !settings.overwrite && std::filesystem::exists( temp_path, dir_ec ) )
{
status = Status::FileExists;
last_error_message =
Expand Down Expand Up @@ -2643,24 +2644,23 @@ bool ImageConverter::process_image( const std::string &input_filename )
return false;
}

// Validate input file exists
// Wrap in try-catch to handle filesystem exceptions on Windows
try
// Validate input file exists using non-throwing error_code overload
std::error_code ec;
if ( !std::filesystem::exists( input_filename, ec ) )
{
if ( !std::filesystem::exists( input_filename ) )
if ( ec )
{
status = Status::FilesystemError;
last_error_message =
std::string( "Filesystem error while checking input file '" ) +
input_filename + "': " + ec.message();
}
else
{
status = Status::InputFileNotFound;
last_error_message =
"Input file does not exist: '" + input_filename + "'.";
return false;
}
}
catch ( const std::filesystem::filesystem_error &e )
{
status = Status::FilesystemError;
last_error_message =
std::string( "Filesystem error while checking input file '" ) +
input_filename + "': " + e.what();
return false;
}

Expand Down
Loading