[refactor] make ceres optional#302
Conversation
| }; | ||
|
|
||
| constexpr double v_6_29__3 = 6.0 * 6.0 * 6.0 / 29.0 / 29.0 / 29.0; | ||
| constexpr double v_29_6__2 = 29.0 * 29.0 / 6.0 / 6.0; |
There was a problem hiding this comment.
literally magic numbers, lol
comment would be super helpful here
| constexpr double v_29_6__2 = 29.0 * 29.0 / 6.0 / 6.0; | ||
|
|
||
| // The non-linear perceptual function of the XYZ to LAB conversion. | ||
| template <typename T> T lab_F( T arg ) |
There was a problem hiding this comment.
why not call it then XYZ_to_LAB?
upd: ah! I can see one below )
| // Go_ = (Rs-Bs) when j == 2, 0 otherwise | ||
| // Go_ = (Gs-Bs) when j == 3, 0 otherwise | ||
| // Bo_ = (Rs-Bs) when j == 4, 0 otherwise | ||
| // Bo_ = (Gs-Bs) when j == 5, 0 otherwise |
There was a problem hiding this comment.
what are these above? Forgotted commented out code or part of explaination?
There was a problem hiding this comment.
this explains what is in the matrix out_rgb_ below
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 91.32% 91.87% +0.54%
==========================================
Files 17 17
Lines 3551 3777 +226
Branches 527 558 +31
==========================================
+ Hits 3243 3470 +227
+ Misses 308 307 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
antond-weta
merged commit 174bfa2
into
AcademySoftwareFoundation:main
3 participants
Description
Implements a non-linear solver making the dependency on Ceres optional. Both solvers are available when built with Ceres, and the Ceres is used by default. The solvers are switchable in runtime, but that option is not currently exposed to the users, only being used in unit tests.
Tests
Yes, full coverage.
There are extensive tests comparing the new solver with the old one.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.