fix: update all os.path.realpath-using call-sites to use real_path instead.

Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>

Author: maxnbk

src/rez/resolved_context.py

@@ -17,7 +17,7 @@
 from rez.utils.formatting import columnise, PackageRequest, ENV_VAR_REGEX, \
     header_comment, minor_header_comment
 from rez.utils.data_utils import deep_del
-from rez.utils.filesystem import TempDirs, is_subdirectory, canonical_path
+from rez.utils.filesystem import TempDirs, is_subdirectory, canonical_path, real_path
 from rez.utils.memcached import pool_memcached_connections
 from rez.utils.logging_ import print_debug, print_error, print_warning
 from rez.utils.which import which
@@ -1896,8 +1896,8 @@ def _adjust_variant_for_bundling(cls, handle: dict, out: bool) -> None:
 
             if is_subdirectory(repo_path, bundle_path):
                 vars_["location"] = os.path.relpath(
-                    os.path.realpath(repo_path),
-                    os.path.realpath(bundle_path)
+                    real_path(repo_path),
+                    real_path(bundle_path)
                 )
 
         # serializing in, make repo absolute

src/rez/serialise.py

@@ -20,7 +20,7 @@
 from rez.package_resources import package_rex_keys
 from rez.utils.scope import ScopeContext
 from rez.utils.sourcecode import SourceCode, early, late, include
-from rez.utils.filesystem import TempDirs
+from rez.utils.filesystem import TempDirs, real_path
 from rez.utils.data_utils import ModifyList
 from rez.exceptions import ResourceError, InvalidPackageError
 from rez.utils.memcached import memcached
@@ -66,7 +66,7 @@ def open_file_for_write(filepath, mode=None):
     yield stream
     content = stream.getvalue()
 
-    filepath = os.path.realpath(filepath)
+    filepath = real_path(filepath)
     tmpdir = tmpdir_manager.mkdtemp()
     cache_filepath = os.path.join(tmpdir, os.path.basename(filepath))
 
@@ -123,7 +123,7 @@ def load_from_file(filepath: str, format_=FileFormat.py, update_data_callback=No
     Returns:
         dict:
     """
-    filepath = os.path.realpath(filepath)
+    filepath = real_path(filepath)
     cache_filepath = file_cache.get(filepath)
 
     if cache_filepath:

src/rez/suite.py

@@ -5,6 +5,7 @@
 from __future__ import annotations
 
 from rez.utils.execution import create_forwarding_script
+from rez.utils.filesystem import real_path
 from rez.exceptions import SuiteError, ResolvedContextError
 from rez.resolved_context import ResolvedContext
 from rez.utils.data_utils import cached_property
@@ -458,7 +459,7 @@ def save(self, path, verbose: bool = False):
                 at `path`, then it will be overwritten. Otherwise, if `path`
                 exists, an error is raised.
         """
-        path = os.path.realpath(path)
+        path = real_path(path)
         if os.path.exists(path):
             if self.load_path and self.load_path == path:
                 if verbose:
@@ -528,7 +529,7 @@ def load(cls, path: str) -> Suite:
             raise SuiteError("Failed loading suite: %s" % str(e))
 
         s = cls.from_dict(data)
-        s.load_path = os.path.realpath(path)
+        s.load_path = real_path(path)
         return s
 
     @classmethod

src/rez/system.py

@@ -13,6 +13,7 @@
 from rez.utils.platform_ import platform_
 from rez.exceptions import RezSystemError
 from rez.utils.data_utils import cached_property
+from rez.utils.filesystem import real_path
 
 
 class System(object):
@@ -242,7 +243,7 @@ def rez_bin_path(self):
 
         validation_file = os.path.join(binpath, ".rez_production_install")
         if os.path.exists(validation_file):
-            return os.path.realpath(binpath)
+            return real_path(binpath)
 
         return None
 

src/rez/utils/filesystem.py

@@ -329,8 +329,8 @@ def make_tmp_name(name):
 
 def is_subdirectory(path_a, path_b) -> bool:
     """Returns True if `path_a` is a subdirectory of `path_b`."""
-    path_a = os.path.realpath(path_a)
-    path_b = os.path.realpath(path_b)
+    path_a = real_path(path_a)
+    path_b = real_path(path_b)
     try:
         relative = os.path.relpath(path_a, path_b)
     except ValueError:

src/rez/utils/py_dist.py

@@ -6,6 +6,7 @@
 Functions for converting python distributions to rez packages.
 """
 from rez.exceptions import RezSystemError
+from rez.utils.filesystem import real_path
 import importlib.metadata as importlib_metadata
 import shutil
 import sys
@@ -194,7 +195,7 @@ def convert_dist(name, dest_path, make_variant: bool = True, ignore_dirs=None,
             files = set()
             for file in installed_files:
                 path = os.path.join(eggpath, file)
-                path = os.path.realpath(path)
+                path = real_path(path)
 
                 if os.path.isfile(path) and path.startswith(dist.location + os.sep):
                     dir_ = os.path.dirname(path)
@@ -209,7 +210,7 @@ def convert_dist(name, dest_path, make_variant: bool = True, ignore_dirs=None,
             def _dst(p):
                 dst = os.path.relpath(p, dist.location)
                 dst = os.path.join(root_path, dst)
-                return os.path.realpath(dst)
+                return real_path(dst)
 
             for dir_ in dirs:
                 dst_dir = _dst(dir_)

src/rezplugins/build_system/cmake.py

@@ -16,6 +16,7 @@
 from rez.utils.platform_ import platform_
 from rez.config import config
 from rez.utils.which import which
+from rez.utils.filesystem import real_path
 from rez.vendor.schema.schema import Or
 from rez.shells import create_shell
 import argparse
@@ -150,9 +151,9 @@ def _pr(s) -> None:
 
         # execute cmake within the build env
         _pr("Executing: %s" % ' '.join(cmd))
-        if not os.path.abspath(build_path):
+        if not os.path.isabs(build_path):
             build_path = os.path.join(self.working_dir, build_path)
-            build_path = os.path.realpath(build_path)
+            build_path = real_path(build_path)
 
         actions_callback = functools.partial(
             self._add_build_actions,