Commit f3db9fb
committed
Fix rex parent_environ case sensitivity on Windows
On Windows env-var keys are case-insensitive natively. os.environ
preserves that contract via os._Environ, but a plain dict copy of it
(or any user-built dict) does not. Until now, ActionManager consumed
whatever Mapping the caller passed as-is, so a package commands()
that referenced env.SomeVariable against a parent_environ holding the
same key under a different case raised RexUndefinedVariableError.
Wrap the caller-supplied parent_environ in a small read-only
case-insensitive proxy on the Windows path only. The proxy is module
private; the wrapping is gated on platform_.name == "windows" and is
idempotent so re-entering the gate is a no-op. Linux and macOS take
the existing identity assignment unchanged.
Also adds a Windows-only regression test that mirrors the issue
reproducer and asserts both direct lookup and end-to-end rex code
paths against a mixed-case parent_environ.
Closes #2089
Reported by @nrusch.
Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>1 parent dc6b3a1 commit f3db9fb
2 files changed
Lines changed: 75 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | | - | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
204 | 214 | | |
205 | 215 | | |
206 | 216 | | |
| |||
447 | 457 | | |
448 | 458 | | |
449 | 459 | | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
450 | 489 | | |
451 | 490 | | |
452 | 491 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
547 | 547 | | |
548 | 548 | | |
549 | 549 | | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
550 | 583 | | |
551 | 584 | | |
552 | 585 | | |
0 commit comments