RFC: Convert package copy process to a new plugin type#2077
Draft
nrusch wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new
copy_processplugin type to handle copying of package payloads.PLEASE NOTE: I'm submitting this in a very raw draft form, just to take the temperature on whether this feels like a valuable addition to
rezin general.The initial submission is a straight cherry-pick of what we have internally. I have resolved the small number of import-related merge conflicts, but I have not validated the code for correctness yet, so please don't feel the need to review the code itself (thoroughly or at all) at this stage. I'm really just interested in any input on the general shape of this.
In addition to fixing anything that I may have broken during cherry-picking and adding some new tests, I would also be planning to do some final polish before considering this "ready" for public consumption. We also have an
rsyncplugin implementation that I think we could roll into this as well (though I need to double-check that).