Skip to content

Commit 997919f

Browse files
Priyanshu RajPriyanshu Raj
authored andcommitted
feat: initial engineering standards and automation setup
0 parents  commit 997919f

12 files changed

Lines changed: 1437 additions & 0 deletions

.github/pull_request_template.md

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
# Pull Request Template
2+
3+
## Description
4+
5+
Please provide a clear and concise description of the changes proposed in this PR. Detail the problem being solved and the technical approach chosen.
6+
7+
## Type of Change
8+
9+
- [ ] 🚀 Feature (New capability for AI, SaaS, or Infrastructure)
10+
- [ ] 🐛 Bug Fix (Resolves an active issue)
11+
- [ ] 🔒 Security / Compliance (Addresses HIPAA/SOC2/PII vulnerability or control)
12+
- [ ] ⚙️ Refactor / Chore (Clean up, performance optimization, dependency bump)
13+
- [ ] 📝 Documentation (Updates to setup, standards, or API docs)
14+
15+
## Scope of Impact
16+
17+
- [ ] **AI & LLM Infrastructure:** PyTorch pipelines, model gateways, RAG, custom agents.
18+
- [ ] **Product & SaaS Platform:** Next.js UI, FastAPI/Go backend services, database migrations.
19+
- [ ] **Cloud & DevOps Automation:** Terraform IaC, Kubernetes configurations, GitHub Actions.
20+
- [ ] **Security & Compliance:** PII masking middleware, authorization rules, auditing tools.
21+
22+
---
23+
24+
## SDLC Quality Checklist
25+
26+
Please verify that each of the following requirements is completed before marking this PR as ready for review:
27+
28+
### 1. Code Quality & Formatting
29+
- [ ] Code compiles and builds locally without errors or warnings.
30+
- [ ] Code styles adhere to the language-specific formatting standard (Prettier, Black, Go fmt).
31+
- [ ] No temporary debug logs, print statements, or commented-out code blocks are left in.
32+
33+
### 2. Testing & Verification
34+
- [ ] Unit tests written and passing for all modified logic (FastAPI, Go, PyTorch).
35+
- [ ] Integration or E2E tests run successfully (Playwright, regression suites).
36+
- [ ] Test coverage meets the team threshold (minimum 80% coverage on new code).
37+
38+
### 3. Compliance & Security by Design
39+
- [ ] **PII Masking:** Verified that personal data (PII) is sanitized before transit to LLMs or external logging.
40+
- [ ] **Security Scans:** Local dependency vulnerability scanning run and verified clean (e.g., `npm audit`, `safety check`).
41+
- [ ] **HIPAA/SOC2:** Audited modifications against least-privilege policies, secure database queries, and log auditing.
42+
43+
### 4. Release Readiness
44+
- [ ] Release checklist followed (see [release-management.md](file:///Users/acadify/Desktop/engineering%20standards/standards/release-management.md)).
45+
- [ ] SemVer impact identified: [Major / Minor / Patch].
46+
- [ ] Changelog draft or release notes draft included below (if applicable).
47+
48+
---
49+
50+
## Verification Evidence
51+
52+
Provide outputs, command logs, or screenshots confirming that the changes have been verified. For UI changes, please attach screenshots or screen recordings showing the UI behavior in different viewports.
53+
54+
### Local Test Output Snippet
55+
```bash
56+
# Paste test run results here
57+
```

.github/workflows/lint.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
name: Lint Markdown
2+
3+
on:
4+
push:
5+
branches: [ main ]
6+
pull_request:
7+
branches: [ main ]
8+
9+
jobs:
10+
lint:
11+
runs-on: ubuntu-latest
12+
13+
steps:
14+
- name: Checkout code
15+
uses: actions/checkout@v4
16+
17+
- name: Setup Node.js
18+
uses: actions/setup-node@v4
19+
with:
20+
node-version: 20
21+
cache: 'npm'
22+
23+
- name: Install dependencies
24+
run: npm install
25+
26+
- name: Run Markdown Lint
27+
run: npm run lint

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
node_modules/
2+
.DS_Store

.husky/pre-commit

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
npx markdownlint "**/*.md" --ignore node_modules

.markdownlint.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"default": true,
3+
"MD013": false,
4+
"MD024": {
5+
"siblings_only": true
6+
},
7+
"MD033": false,
8+
"MD041": false
9+
}

README.md

Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
# Acadify Solution — Engineering Standards & Practices
2+
3+
Welcome to the **Acadify Solution Engineering Standards** repository. This centralized resource defines our internal engineering policies, code quality guidelines, and compliance requirements.
4+
5+
As a distributed team of senior developers building high-reliability AI systems, secure cloud architectures, and scalable SaaS platforms, we hold ourselves to rigorous development standards. Adhering to these guidelines ensures our code is secure, scalable, maintainable, and aligned with industry compliance standards (including HIPAA and SOC2).
6+
7+
---
8+
9+
## 🗺️ Standards Navigation
10+
11+
Our development practices are structured into four main areas:
12+
13+
| Standards Document | Key Topics Covered |
14+
| :--- | :--- |
15+
| 🌿 **[Branching & Git Guidelines](standards/branching-git.md)** | Branching models (Trunk-Based / Git Flow), Branch Protection policies, and Conventional Commits. |
16+
| 🛡️ **[Coding & Security Practices](standards/coding-practices.md)** | AI/LLM safety, PII Masking, HIPAA/SOC2 design rules, SaaS patterns, and static analysis benchmarks. |
17+
| 👥 **[Peer Reviews & PR Guidelines](standards/peer-reviews.md)** | PR criteria, Author self-audits, Reviewer responsibilities, and PR templates. |
18+
| 🚀 **[Release & Versioning](standards/release-management.md)** | Semantic Versioning (SemVer), release checklists, changelog management, and hotfix paths. |
19+
20+
---
21+
22+
## 🛠️ Automated Quality & Tooling
23+
24+
To minimize manual overhead and maintain a consistent baseline, we enforce automatic linting and code styles across all repositories via git hooks and CI checkups.
25+
26+
### Local Environment Setup
27+
28+
When you clone any Acadify repository (including this standards repo), follow these steps to initialize the automated quality tools:
29+
30+
#### Prerequisites
31+
32+
* Node.js (LTS version 20+)
33+
* pnpm / npm / yarn (We recommend `npm` or `pnpm` depending on repository configurations)
34+
35+
#### Step 1: Install Dependencies
36+
37+
This project uses DevDependencies to lint documentation files using `markdownlint-cli` and manage git hooks using `husky`.
38+
39+
```bash
40+
npm install
41+
```
42+
43+
#### Step 2: Enable Git Hooks (Husky)
44+
45+
Husky will automatically configure hook directories based on the `"prepare"` script in `package.json`. If it does not run, you can initialize it manually:
46+
47+
```bash
48+
npx husky
49+
```
50+
51+
### Formatting and Linting Checks
52+
53+
#### Manual Check
54+
55+
You can run the markdown lint checks on demand:
56+
57+
```bash
58+
# Run lint check
59+
npm run lint
60+
61+
# Auto-fix fixable markdown format issues
62+
npm run lint:fix
63+
```
64+
65+
#### Commit-time Hooks
66+
67+
Husky prevents malformed documentation commits by automatically running `markdownlint` before your commit goes through. If linting fails, resolve the errors indicated in the command-line output and re-run your `git commit` command.
68+
69+
#### Continuous Integration (CI)
70+
71+
A GitHub Actions workflow (`.github/workflows/lint.yml`) runs on every pull request targeting `main`. PRs cannot be merged if the linting checks fail.
72+
73+
---
74+
75+
## 🤝 Contribution Guidelines
76+
77+
We treat our standards as living documentation. If you spot a gap, outdated practice, or have an optimization proposal:
78+
79+
1. Create a branch named `refactor/standards-update-<topic>`.
80+
2. Propose the standard updates and verify they comply with the markdown linting rules.
81+
3. Open a Pull Request and assign it to the engineering leads for review.
82+
83+
---
84+
85+
© 2026 Acadify Solution. All rights reserved. Distributed engineering partner.

0 commit comments

Comments
 (0)