fix(security): 2 improvements across 2 files#1050
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Command Injection via Unsanitized File Path in openHtml - Security: Arbitrary Code Execution via Dynamic Script Loading in loadRpcMethodsByScripts Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Command Injection via Unsanitized File Path in openHtml - Security: Arbitrary Code Execution via Dynamic Script Loading in loadRpcMethodsByScripts Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Critical| File:packages/chopsticks/src/utils/open-html.ts:L4The
openHtmlfunction inopen-html.tsdirectly interpolates a user-providedfilePathinto a shell command executed viaexecSync. ThefilePathparameter is not sanitized or validated, allowing an attacker to inject arbitrary shell commands. For example, a path like; rm -rf /would be executed by the shell. This is a classic command injection vulnerability.Solution
Use
execFileSyncorspawnwith the file path as an argument array instead of string interpolation, or sanitize/validate the filePath usingpath.resolve()and ensure it doesn't contain shell metacharacters. Alternatively, use a cross-platform library likeopenoropnthat handles this securely.Changes
packages/chopsticks/src/utils/open-html.ts(modified)packages/chopsticks/src/plugins/index.ts(modified)