[model,network] Bugfix network model and test

Author: gilbertmike

accelforge/model/_looptree/reuse/symbolic/symbolic/_network.py

@@ -79,7 +79,7 @@ def accumulate_child_result(
             last_fanout = last_fanout.get(node.name, 1)
             if isinstance(relevancy, Irrelevant):
                 # Cost of multicasting is the cost of delivering along the dimension
-                multicast_hops = (shape_repeats - 1) * last_fanout
+                multicast_hops = shape_repeats * last_fanout
                 multicast_cost = multicast_hops * volume
                 self.overall_max_hops += multicast_hops
 
@@ -93,9 +93,9 @@ def accumulate_child_result(
                 # the dimension with shape as stride
                 # TODO: we should use the actual stride
                 total_unicast_cost = (
-                    0.5 * (shape_repeats - 1) * shape_repeats * last_fanout * volume
+                    0.5 * (shape_repeats + 1) * shape_repeats * last_fanout * volume
                 )
-                max_unicast_hops = (shape_repeats - 1) * last_fanout
+                max_unicast_hops = shape_repeats * last_fanout
                 self.overall_max_hops += max_unicast_hops
 
                 accumulated_network_stats.total_hops += total_unicast_cost

accelforge/model/_looptree/reuse/symbolic/symbolic/_symbolic.py

@@ -633,9 +633,9 @@ def handle_repeated_value(repeated_shape):
                 shape_repeats, reuse_parent_accesses
             )
 
-            network_analyzer.accumulate_child_result(
-                child_result, info, shape_repeats, einsum_name, child_shape, node
-            )
+        network_analyzer.accumulate_child_result(
+            child_result, info, shape_repeats, einsum_name, child_shape, node
+        )
 
         for einsum, child_steps in child_result.temporal_steps.items():
             if einsum not in result_accumulator.temporal_steps: