Skip to content

Add some wrong things#418

Open
EmmaDawsonDev wants to merge 5 commits intomainfrom
testing-axe
Open

Add some wrong things#418
EmmaDawsonDev wants to merge 5 commits intomainfrom
testing-axe

Conversation

@EmmaDawsonDev
Copy link
Copy Markdown
Member

Describe your changes

Screenshots - If Any (Optional)

Link to issue

Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.
  • I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
    and it shows no errors.

Additional Information (Optional)

Any additional information that you want to give us.

Copy link
Copy Markdown

@accesslint accesslint Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, welcome to AccessLint! This is your first review on this repo. Going forward, AccessLint will check your pull requests for web accessibility issues and flag anything new. Here's what we found.

Found 2 issues across 2 rules.

export const ImagesTemplate = () => {
return (
<>
<img src="/images/imagesTemplate/oldPaperTexture.jpg"></img>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 1.1.1: Image element missing alt attribute.

Images must have alternate text. Add an alt attribute to <img> elements. Decorative images may use an empty alt attribute (alt=""), role='none', or role='presentation'.

Details

Adjacent text: /* eslint-disable jsx-a11y/no-noninteractive-tabindex /
/
eslint-disable jsx-a11y/alt-text */
impo

Every image needs an alt attribute. For informative images, describe the content or function concisely. For decorative images (backgrounds, spacers, purely visual flourishes), use alt='' to hide them from screen readers. Never omit alt entirely—screen readers may read the filename instead.

<img src="/images/imagesTemplate/oldPaperTexture.jpg"></img>
<div role="button">
Testing
<div role="menuitem">123</div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 1.3.1: Role "menuitem" must be contained within: menu, menubar, group.

Certain ARIA roles must be contained within specific parent roles.

Details

Some ARIA roles represent items that must exist within specific container roles. For example, a listitem must be within a list, a tab must be within a tablist. Wrap the element in the appropriate parent, or use native HTML elements that provide this structure (e.g., <li> inside <ul>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant