Skip to content

Commit c99f609

Browse files
authored
Merge pull request #37 from AckeeCZ/feat/33-remove-cf
πŸ”₯ Remove cloud functions starter
2 parents 144f284 + f2915fb commit c99f609

26 files changed

Lines changed: 9 additions & 480 deletions

β€Ž.github/workflows/create-projects.ymlβ€Ž

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
matrix:
20-
create-app-command: ["create-node-app cloudfunctions", "create-node-app cloudrun", "create-node-app cloudrun-graphql"]
20+
create-app-command: ["create-node-app cloudrun", "create-node-app cloudrun-graphql"]
2121
runs-on: ubuntu-latest
2222

2323
steps:
@@ -58,11 +58,7 @@ jobs:
5858
- name: Run start
5959
working-directory: ./node-app
6060
run: |
61-
if [[ "${{ matrix.create-app-command }}" != "create-node-app cloudfunctions" ]]; then
62-
npm run start &
63-
start_pid=$!
64-
sleep 10
65-
kill $start_pid
66-
else
67-
echo "Skipping 'Run start' for create-node-app cloudfunctions."
68-
fi
61+
npm run start &
62+
start_pid=$!
63+
sleep 10
64+
kill $start_pid

β€ŽREADME.mdβ€Ž

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ CLI to help you set up Node.js TypeScript project. Set up project includes
1010

1111
- code style tools (prettier, lint)
1212
- testing (using jest)
13-
- infrastructure files of your choice (Docker, Cloud Functions, etc.)
13+
- infrastructure files of your choice (Docker, etc.)
1414
- GitLab CI and npm ci-\* scripts (for Ackee CI/CD pipelines)
1515

1616
## Usage
@@ -30,11 +30,9 @@ Options:
3030
Starters available:
3131
cloudrun Cloud Run + express
3232
cloudrun-graphql Cloud Run + graphql
33-
cloudfunctions Cloud Functions + graphql
3433
```
3534

3635
Supported starter templates:
3736

3837
- [Cloud Run](./starter/cloudrun/README.md)
3938
- [GraphQL Cloud Run](./starter/cloudrun-graphql/README.md)
40-
- [Cloud Functions](./starter/cloudfunctions/README.md)

β€Žlib/Bootstrap.jsβ€Ž

Lines changed: 1 addition & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žlib/Bootstrap.js.mapβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žlib/cloudfunctions/CloudFunctionsStarter.jsβ€Ž

Lines changed: 0 additions & 105 deletions
This file was deleted.

β€Žlib/cloudfunctions/CloudFunctionsStarter.js.mapβ€Ž

Lines changed: 0 additions & 1 deletion
This file was deleted.

β€Žsrc/Bootstrap.tsβ€Ž

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { CloudFunctionsStarter } from './cloudfunctions/CloudFunctionsStarter.js'
21
import { CloudRunStarter } from './cloudrun/CloudRunStarter.js'
32
import { Npm } from './Npm.js'
43
import { Toolbelt } from './Toolbelt.js'
@@ -12,11 +11,7 @@ import { logger } from './Logger.js'
1211
import { Starter } from './Starter.js'
1312

1413
export class Bootstrap {
15-
protected starters: Starter[] = [
16-
new CloudRunStarter(),
17-
new CloudFunctionsStarter(),
18-
new GraphQLStarter(),
19-
]
14+
protected starters: Starter[] = [new CloudRunStarter(), new GraphQLStarter()]
2015

2116
public runCLI(args: string[]) {
2217
const cli = yargs(hideBin(args))

β€Žsrc/cloudfunctions/CloudFunctionsStarter.tsβ€Ž

Lines changed: 0 additions & 116 deletions
This file was deleted.

β€Žstarter/cloudfunctions/.env.jsoncβ€Ž

Lines changed: 0 additions & 6 deletions
This file was deleted.

β€Žstarter/cloudfunctions/.eslint.tsconfig.jsonβ€Ž

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
Β (0)