Add resolution for Arch.anima in resolution.py#2520
Conversation
|
Not convinced this is actually needed or an improvement. Regardless of what the model claims are ideal resolutions, the mechnism in the plugin has clear goals:
IME Anima works fine at resolutions lower than 512, and its issues with higher resolutions can't be fixed with this code change (it needs tiling, which is only implemented in the upscale path). |
|
Thanks for explaining in detail. That indeed makes sense, but i was approaching this with keeping those refine passes within the Anima's preferred resolution, and though lower resolutions (<512) doesn't break as bad as sdxl or sd1.5, it causes degradation in quality or little to no quality improvement at all. Since the purpose of refine is to improve the result, rather than honoring the canvas resolution, i think keeping the Anima lower bound to 512 is beneficial. |
No that is not the purpose. If you want higher resolution, increase resolution. There is no reason refine should do that on its own behind the curtain. It's a strictly worse way to do it, because results of refine have to be downscaled to fit into the canvas, and the next refine picks up the low-res result. If you increase canvas resolution, results are better. |
That was my fault for not being clear. For refining the whole image, its always better to increase your canvas resolution to get better results. What i was referring to specifically is refining a selection. I would expect to get more quality/detailed result if i refine a selection area, but currently its not (i have seen other users report the same). For example, if i have a 1M canvas, and i select a small area, say a face of around 300px, and i refine it, i don't get improved result at all, because the lower bound is set to 256 px, where it will not upscale the image to do a refine pass. So by increasing the lower bound to 512px, we can get better results. So do you think it justifies the lower bound for selection, or can it be handled in some other way? P.S. Can you check the PR for the tooling node? |
|
It was not unclear. Yes A1111 folks are regularly confused about this, there's some unlearning to do and they hate that? In selection case we can
I don't want to implement 2. because people should use 3. |
Fair enough. I understand what you're saying. My goal was mainly to improve small selection refinement, but I can see why you prefer tying the behavior directly to the canvas resolution keeping the control with the user rather than background auto scaling. |
Added missing Anima preferred resolution.