Iterate seed after apply#2539
Open
wraybowling wants to merge 1 commit into
Open
Conversation
wraybowling
force-pushed
the
live-iterate-seed-after-apply
branch
from
3a56c2d to
e12b5d6
Compare
Owner
|
Let's call it "Increment" instead of iterate. What happens when loading settings which use the old true/false? Might have to add some kind of migration. Also the comparisons to the enum name don't look like they're actually valid code... |
Author
|
Noted! I see I also need to learn how to run your tests to get a passing build. I'll have another pass at it soon. Thanks for looking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is my attempt to add a feature for a quirk that bothered me. In live mode, I prefer punching in 1 as my seed number and iterating by 1 as I accept changes. This allows me to return to seeds that worked well just by using small simple numbers that are easy to remember.
At the time of this PR being created I have not added translations yet and I am still testing. Big fan of the project! First time contributing here. Not vibe coded, fwiw.