fix: unmount old plugin before loading new version on reload

Call acode.unmountPlugin() before loading the new plugin script in loadPlugin.js.
This ensures the OLD destroy() callback runs while it still exists, properly
cleaning up sidebar apps, commands, event listeners, and filesystem handlers
from the previous plugin instance.

Without this, the new script overwrites the old unmount callback via
acode.setPluginUnmount(), making the old destroy unreachable and causing
resource leaks (duplicate sidebar icons, stale event handlers, etc.).

Also removes the old <script> tag so the browser fetches the new source.

Author: 埃博拉酱

src/lib/loadPlugin.js

@@ -8,6 +8,24 @@ export default async function loadPlugin(pluginId, justInstalled = false) {
 	const baseUrl = await helpers.toInternalUri(Url.join(PLUGIN_DIR, pluginId));
 	const cacheFile = Url.join(CACHE_STORAGE, pluginId);
 
+	// Unmount the old version before loading the new one.
+	// This MUST be done here by the framework, not by the new plugin code itself,
+	// because once the new script loads, it calls acode.setPluginUnmount(id, newDestroy)
+	// which overwrites the old version's destroy callback. At that point the old
+	// destroy — which holds references to the old sidebar app, commands, event
+	// listeners, etc. — is lost and can never be called. Letting the framework
+	// invoke unmountPlugin() first ensures the OLD destroy() runs while it still
+	// exists, so all old-version resources are properly cleaned up.
+	try {
+		acode.unmountPlugin(pluginId);
+	} catch (e) {
+		// Expected to throw on first install when no unmount callback is registered
+	}
+
+	// Remove the old <script> tag so the browser fetches the new source.
+	const oldScript = document.getElementById(`${pluginId}-mainScript`);
+	if (oldScript) oldScript.remove();
+
 	const pluginJson = await fsOperation(
 		Url.join(PLUGIN_DIR, pluginId, "plugin.json"),
 	).readFile("json");