Merge remote-tracking branch 'upstream/main' into fileobject-feature

Author: RohitKushvaha01

.github/CODEOWNERS

@@ -0,0 +1,6 @@
+.github/CODEOWNERS @Acode-Foundation
+
+# workflows
+.github/workflows/nightly-build.yml @unschooledgamer
+.github/workflows/on-demand-preview-releases-PR.yml @unschooledgamer
+.github/workflows/community-release-notifier.yml @unschooledgamer

.github/workflows/nightly-build.yml

@@ -1,3 +1,5 @@
+# Implement to use environment secrets someday, At the moment GH Actions doesn't support those in reusable workflows (ref: https://github.com/actions/runner/issues/1490)
+# at least that's what I found.
   name: Nightly Build
 
   on:
@@ -28,6 +30,12 @@
           value: ${{ jobs.build.result }}
 
     workflow_dispatch:
+      inputs:
+        skip_tagging_and_releases:
+          required: false
+          default: true
+          type: boolean
+          description: Skips Tagging & releases, since workflow_call isn't available for github.event_name, default is true
 
   concurrency:
     # Allow only one workflow per any non-`main` branch.
@@ -51,7 +59,7 @@
       permissions:
 #        contents write is needed to create Nightly Releases.
         contents: write
-        issues: write
+#        issues: write
         pull-requests: write
 
       outputs:
@@ -89,13 +97,16 @@
           uses: actions/checkout@v4
           with:
             fetch-depth: 0 # Required for tags
+            # persists credentials locally if tagging and releases are not skipped.
+            persist-credentials: ${{ ! inputs.skip_tagging_and_releases }}
+            ref: ${{ (inputs.is_PR && inputs.PR_NUMBER) && github.event.pull_request.head.sha || '' }}
 
         - name: Set up Java 21
           uses: actions/setup-java@v4
           with:
             distribution: 'temurin'
             java-version: '21'
-            cache: ${{ (github.ref == 'refs/heads/main' && 'gradle') || '' }}
+            cache: ${{ (!(inputs.is_PR && inputs.PR_NUMBER) && github.ref == 'refs/heads/main' && 'gradle') || '' }}
 
         - name: Set up Node.js
           uses: actions/setup-node@v4
@@ -149,6 +160,9 @@
         - name: Install Node.js Packages
           run: npm install
 
+        - name: Install Cordova CLI
+          run: npm install -g cordova
+
         - name: Run npm setup
           run: npm run setup
 
@@ -207,7 +221,8 @@
               platforms/android/app/build/outputs/apk/debug/app-debug.apk
             body: |
               Automated Nightly (pre-release) Releases for Today
-              \n\n[Compare Changes](https://github.com/${{ github.repository }}/compare/${{ env.TAG_COMMIT }}...${{ github.sha }})
+              
+              [Compare Changes](https://github.com/${{ github.repository }}/compare/${{ env.TAG_COMMIT }}...${{ github.sha }})
 
         - name: Update Last Comment by bot (If ran in PR)
           if: inputs.is_PR

.github/workflows/on-demand-preview-releases-PR.yml

@@ -1,7 +1,7 @@
 name: On Demand Preview Releases for PR
 #  avoids paths like .md, and anything in .github folder
 on:
-  pull_request:
+  pull_request_target:
     paths-ignore:
       - '!*.md'
 #      - '.github/**'
@@ -38,6 +38,9 @@ jobs:
         with:
           clean: false
           fetch-depth: 0
+          persist-credentials: false
+          # Checkout pull request HEAD commit instead of merge commit
+          ref: ${{ github.event.pull_request.head.sha }}
 
       - name: Remove Manually added PR Label
         if: |

package-lock.json

@@ -34,12 +34,12 @@
       },
       "cordova-plugin-websocket": {},
       "cordova-plugin-buildinfo": {},
-      "cordova-plugin-system": {},
       "cordova-plugin-browser": {},
       "com.foxdebug.acode.rk.exec.terminal": {},
       "com.foxdebug.acode.rk.exec.proot": {},
       "cordova-plugin-sftp": {},
-      "com.foxdebug.acode.rk.nativeFile": {}
+      "com.foxdebug.acode.rk.nativeFile": {},
+      "cordova-plugin-system": {}
     },
     "platforms": [
       "android"
@@ -64,7 +64,6 @@
     "@types/url-parse": "^1.4.11",
     "autoprefixer": "^10.4.21",
     "babel-loader": "^10.0.0",
-    "com.foxdebug.acode.rk.exec.proot": "file:src/plugins/proot",
     "com.foxdebug.acode.rk.exec.terminal": "file:src/plugins/terminal",
     "cordova-android": "^14.0.1",
     "cordova-clipboard": "^1.3.0",

package.json

@@ -426,5 +426,7 @@
 	"reviews": "التقييمات",
 	"overview": "نظرة عامة",
 	"contributors": "المساهمون",
-	"quicktools:hyphen": "إدراج شرطة"
+	"quicktools:hyphen": "إدراج شرطة",
+	"check for app updates": "Check for app updates",
+	"prompt update check consent message": "Acode can check for new app updates when you're online. Enable update checks?"
 }

src/lang/ar-ye.json

@@ -427,5 +427,7 @@
 	"reviews": "reviews",
 	"overview": "Overview",
 	"contributors": "Contributors",
-	"quicktools:hyphen": "Insert hyphen symbol"
+	"quicktools:hyphen": "Insert hyphen symbol",
+	"check for app updates": "Check for app updates",
+	"prompt update check consent message": "Acode can check for new app updates when you're online. Enable update checks?"
 }

src/lang/be-by.json

@@ -426,5 +426,7 @@
 	"reviews": "রিভিউ",
 	"overview": "সংক্ষিপ্ত বিবরণ",
 	"contributors": "অবদানকারী",
-	"quicktools:hyphen": "হাইফেন যুক্ত করুন"
+	"quicktools:hyphen": "হাইফেন যুক্ত করুন",
+	"check for app updates": "Check for app updates",
+	"prompt update check consent message": "Acode can check for new app updates when you're online. Enable update checks?"
 }

src/lang/bn-bd.json

@@ -426,5 +426,7 @@
 	"reviews": "reviews",
 	"overview": "Overview",
 	"contributors": "Contributors",
-	"quicktools:hyphen": "Insert hyphen symbol"
+	"quicktools:hyphen": "Insert hyphen symbol",
+	"check for app updates": "Check for app updates",
+	"prompt update check consent message": "Acode can check for new app updates when you're online. Enable update checks?"
 }

src/lang/cs-cz.json

@@ -426,5 +426,7 @@
 	"reviews": "Bewertungen",
 	"overview": "Überblick",
 	"contributors": "Mitwirkende",
-	"quicktools:hyphen": "Bindestrich-Symbol einfügen"
+	"quicktools:hyphen": "Bindestrich-Symbol einfügen",
+	"check for app updates": "Check for app updates",
+	"prompt update check consent message": "Acode can check for new app updates when you're online. Enable update checks?"
 }