fix: parse localstorage data safely

Author: bajrangCoder

src/lib/recents.js

@@ -8,13 +8,15 @@ const recents = {
 	 * @returns {Array<String>}
 	 */
 	get files() {
-		return JSON.parse(localStorage.recentFiles || "[]");
+		const files = helpers.parseJSON(localStorage.recentFiles);
+		return Array.isArray(files) ? files : [];
 	},
 	/**
 	 * @returns {{url: String, opts: Map<String, String>}[]}
 	 */
 	get folders() {
-		return JSON.parse(localStorage.recentFolders || "[]");
+		const folders = helpers.parseJSON(localStorage.recentFolders);
+		return Array.isArray(folders) ? folders : [];
 	},
 	set files(list) {
 		if (Array.isArray(list)) localStorage.recentFiles = JSON.stringify(list);

src/pages/fileBrowser/fileBrowser.js

@@ -62,7 +62,8 @@ function FileBrowserInclude(mode, info, doesOpenLast = true) {
 	const state = [];
 	/**@type {Array<Storage>} */
 	const allStorages = [];
-	let storageList = JSON.parse(localStorage.storageList || "[]");
+	let storageList = helpers.parseJSON(localStorage.storageList);
+	if (!Array.isArray(storageList)) storageList = [];
 
 	let isSelectionMode = false;
 	let selectedItems = new Set();

src/pages/sponsors/sponsors.js

@@ -128,7 +128,10 @@ export default function Sponsors() {
 
 		if (!sponsors.length && "cached_sponsors" in localStorage) {
 			try {
-				sponsors = JSON.parse(localStorage.getItem("cached_sponsors")) || [];
+				const cachedSponsors = helpers.parseJSON(
+					localStorage.getItem("cached_sponsors"),
+				);
+				sponsors = Array.isArray(cachedSponsors) ? cachedSponsors : [];
 			} catch (error) {
 				console.error("Failed to parse cached sponsors", error);
 			}

src/palettes/changeMode/index.js

@@ -1,5 +1,6 @@
 import { getModes } from "cm/modelist";
 import palette from "components/palette";
+import helpers from "utils/helpers";
 import Path from "utils/Path";
 
 export default function changeMode() {
@@ -25,7 +26,7 @@ function onselect(mode) {
 
 	let modeAssociated;
 	try {
-		modeAssociated = JSON.parse(localStorage.modeassoc || "{}");
+		modeAssociated = helpers.parseJSON(localStorage.modeassoc) || {};
 	} catch (error) {
 		modeAssociated = {};
 	}

src/utils/Uri.js

@@ -1,6 +1,15 @@
 import escapeStringRegexp from "escape-string-regexp";
 import path from "./Path";
 
+function parseStorageList() {
+	try {
+		const storageList = JSON.parse(localStorage.storageList || "[]");
+		return Array.isArray(storageList) ? storageList : [];
+	} catch (_) {
+		return [];
+	}
+}
+
 export default {
 	/**
 	 * Parse content uri to rootUri and docID
@@ -81,7 +90,7 @@ export default {
 	 */
 	getVirtualAddress(url) {
 		try {
-			const storageList = JSON.parse(localStorage.storageList || "[]");
+			const storageList = parseStorageList();
 
 			const matches = [];
 			for (let storage of storageList) {

src/utils/helpers.js

@@ -242,7 +242,8 @@ export default {
 		}
 
 		/**@type {string[]} */
-		const storageList = JSON.parse(localStorage.storageList || "[]");
+		const storageList = this.parseJSON(localStorage.storageList);
+		if (!Array.isArray(storageList)) return url;
 		const storageListLen = storageList.length;
 
 		for (let i = 0; i < storageListLen; ++i) {