Skip to content

Commit c2f6644

Browse files
fix(plugin): plugin <script> tags accumulate in <head> when plugin is uninstalled (#1878)
* fix(plugin): plugin <script> tags accumulate in <head> when plugin is uninstalled * chore: fmt changes
1 parent df79e64 commit c2f6644

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/lib/loadPlugin.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ export default async function loadPlugin(pluginId, justInstalled = false) {
2222
}
2323

2424
return new Promise((resolve, reject) => {
25-
const $script = <script src={mainUrl}></script>;
25+
const $script = (
26+
<script id={`${pluginId}-mainScript`} src={mainUrl}></script>
27+
);
2628

2729
$script.onerror = (error) => {
2830
reject(

src/sidebarApps/extensions/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -868,6 +868,8 @@ async function uninstall(id) {
868868
fsOperation(pluginDir).delete(),
869869
state.delete(state.storeUrl),
870870
]);
871+
const pluginMainScript = document.getElementById(`${id}-mainScript`);
872+
if (pluginMainScript) document.head.removeChild(pluginMainScript);
871873
acode.unmountPlugin(id);
872874

873875
const searchInput = container.querySelector('input[name="search-ext"]');

0 commit comments

Comments
 (0)