Skip to content

Fixes/sidebar extension state by clearing and active autocompletion box background #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 2 commits into from
Aug 1, 2025
Merged

Fixes/sidebar extension state by clearing and active autocompletion box background #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5711294
fix: clear filter state from sidebar extension tab
bajrangCoder Aug 1, 2025
888903a
fix: theme autocompletion active line background
bajrangCoder Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
<edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application">
<application android:networkSecurityConfig="@xml/network_security_config" />
<application android:hardwareAccelerated="true" />
<application android:requestLegacyExternalStorage="true" />
<application android:largeHeap="true" />
<application android:requestLegacyExternalStorage="true"/>
</edit-config>
Expand Down
16 changes: 0 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions src/sidebarApps/extensions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,12 @@ function ListItem({ icon, name, id, version, downloads, installed, source }) {
if (searchInput) {
searchInput.value = "";
$searchResult.content = "";
// Reset filter state when clearing search results
currentFilter = null;
filterCurrentPage = 1;
filterHasMore = true;
isFilterLoading = false;
$searchResult.onscroll = null;
updateHeight($searchResult);
$installed.expand();
}
Expand Down Expand Up @@ -650,6 +656,12 @@ async function uninstall(id) {
if (searchInput) {
searchInput.value = "";
$searchResult.content = "";
// Reset filter state when clearing search results
currentFilter = null;
filterCurrentPage = 1;
filterHasMore = true;
isFilterLoading = false;
$searchResult.onscroll = null;
updateHeight($searchResult);
if ($installed.collapsed) {
$installed.expand();
Expand Down
114 changes: 59 additions & 55 deletions src/styles/overrideAceStyle.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,55 +1,59 @@
.ace_mobile-menu,
.ace_tooltip.ace_doc-tooltip {
display: none !important;
}

.ace_editor {
&[data-font="Fira Code"] {
font-feature-settings: 'liga' on, 'calt' on;
-webkit-font-feature-settings: 'liga' on, 'calt' on;
-webkit-font-smoothing: antialiased;
text-rendering: optimizeLegibility;
unicode-bidi: isolate;
}
}

.ace_tooltip {
background-color: rgb(255, 255, 255);
background-color: var(--secondary-color);
color: rgb(37, 37, 37);
color: var(--secondary-text-color);
max-width: 68%;
white-space: pre-wrap;
}

main .ace_editor {
textarea {
user-select: none !important;
pointer-events: none !important;
transform: translate(-100000px, -10000px) !important;
}
}

.ace-container {
height: 100%;
}

.ace_dark.ace_editor.ace_autocomplete .ace_marker-layer .ace_active-line {
background-color: var(--active-color);
}

.ace_dark.ace_editor.ace_autocomplete .ace_completion-highlight {
color: var(--popup-active-color);
}

.ace_dark.ace_editor.ace_autocomplete {
border: 1px solid var(--popup-border-color);
box-shadow: 2px 3px 5px var(--box-shadow-color);
line-height: 1.4;
background: var(--primary-color);
color: var(--primary-text-color);
}

.ace_hidden-cursors .ace_cursor {
opacity: 0.8 !important;
}
.ace_mobile-menu,
.ace_tooltip.ace_doc-tooltip {
display: none !important;
}

.ace_editor {
&[data-font="Fira Code"] {
font-feature-settings:
"liga" on,
"calt" on;
-webkit-font-feature-settings:
"liga" on,
"calt" on;
-webkit-font-smoothing: antialiased;
text-rendering: optimizeLegibility;
unicode-bidi: isolate;
}
}

.ace_tooltip {
background-color: rgb(255, 255, 255);
background-color: var(--secondary-color);
color: rgb(37, 37, 37);
color: var(--secondary-text-color);
max-width: 68%;
white-space: pre-wrap;
}

main .ace_editor {
textarea {
user-select: none !important;
pointer-events: none !important;
transform: translate(-100000px, -10000px) !important;
}
}

.ace-container {
height: 100%;
}

.ace_dark.ace_editor.ace_autocomplete .ace_marker-layer .ace_active-line {
background-color: rgba(from var(--active-color) r g b / 0.3);
}

.ace_dark.ace_editor.ace_autocomplete .ace_completion-highlight {
color: var(--popup-active-color);
}

.ace_dark.ace_editor.ace_autocomplete {
border: 1px solid var(--popup-border-color);
box-shadow: 2px 3px 5px var(--box-shadow-color);
line-height: 1.4;
background: var(--primary-color);
color: var(--primary-text-color);
}

.ace_hidden-cursors .ace_cursor {
opacity: 0.8 !important;
}