Skip to content

fix: terminal #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RohitKushvaha01 wants to merge 3 commits into from
Closed

fix: terminal #1738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c0ca08
fix: terminal
RohitKushvaha01 Dec 11, 2025
5d6a019
fix: package.json
RohitKushvaha01 Dec 11, 2025
50a994f
.
RohitKushvaha01 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"cordova-plugin-browser": {},
"cordova-plugin-sftp": {},
"cordova-plugin-system": {},
"com.foxdebug.acode.rk.exec.terminal": {},
"com.foxdebug.acode.rk.exec.proot": {}
"com.foxdebug.acode.rk.exec.proot": {},
"com.foxdebug.acode.rk.exec.terminal": {}
},
"platforms": [
"android"
Expand Down Expand Up @@ -129,4 +129,4 @@
"yargs": "^18.0.0"
},
"browserslist": "cover 100%,not android < 5"
}
}
4 changes: 0 additions & 4 deletions src/components/terminal/terminalManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,10 +588,6 @@ class TerminalManager {
// Remove from map
this.terminals.delete(terminalId);

if (this.getAllTerminals().size <= 0) {
Executor.stopService();
}

console.log(`Terminal ${terminalId} closed`);
} catch (error) {
console.error(`Error closing terminal ${terminalId}:`, error);
Expand Down
29 changes: 16 additions & 13 deletions src/plugins/terminal/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
<config-file parent="/*" target="AndroidManifest.xml" />

<source-file src="src/android/Executor.java" target-dir="src/com/foxdebug/acode/rk/exec/terminal" />
<source-file src="src/android/TerminalService.java" target-dir="src/com/foxdebug/acode/rk/exec/terminal" />

<source-file src="src/android/AlpineDocumentProvider.java" target-dir="src/com/foxdebug/acode/rk/exec/terminal" />
<source-file src="src/android/KeepAliveService.java" target-dir="src/com/foxdebug/acode/rk/exec/terminal" />


<source-file src="scripts/init-sandbox.sh" target-dir="assets"/>
<source-file src="scripts/init-alpine.sh" target-dir="assets"/>
Expand All @@ -31,35 +31,38 @@

<config-file target="AndroidManifest.xml" parent="./application">
<provider
android:name="com.foxdebug.acode.rk.exec.terminal.AlpineDocumentProvider"
android:authorities="${applicationId}.documents"
android:exported="true"
android:grantUriPermissions="true"
android:icon="@mipmap/ic_launcher"
android:permission="android.permission.MANAGE_DOCUMENTS">
android:name="com.foxdebug.acode.rk.exec.terminal.AlpineDocumentProvider"
android:authorities="${applicationId}.documents"
android:exported="true"
android:grantUriPermissions="true"
android:icon="@mipmap/ic_launcher"
android:permission="android.permission.MANAGE_DOCUMENTS">
<intent-filter>
<action android:name="android.content.action.DOCUMENTS_PROVIDER" />
</intent-filter>
</provider>

<service
android:name="com.foxdebug.acode.rk.exec.terminal.TerminalService"
android:name="com.foxdebug.acode.rk.exec.terminal.KeepAliveService"
android:enabled="true"
android:foregroundServiceType="specialUse"
android:exported="true" />

</config-file>




<!-- DO NOT EDIT OR REMOVE-->
<config-file target="AndroidManifest.xml" parent="/manifest"></config-file>


<config-file target="AndroidManifest.xml" parent="/manifest">
<uses-permission android:name="android.permission.WAKE_LOCK"/>
<uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_SPECIAL_USE"/>
<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
</config-file>


<!-- DO NOT EDIT OR REMOVE-->
<config-file target="AndroidManifest.xml" parent="/manifest"></config-file>

</platform>
</plugin>
Loading