Skip to content

feat: Enhance addIcon to support svg currentColor#1760

Merged
bajrangCoder merged 2 commits intoAcode-Foundation:mainfrom
bajrangCoder:svg-icon-bug
Dec 21, 2025
Merged

feat: Enhance addIcon to support svg currentColor#1760
bajrangCoder merged 2 commits intoAcode-Foundation:mainfrom
bajrangCoder:svg-icon-bug

Conversation

@bajrangCoder
Copy link
Copy Markdown
Member

@bajrangCoder bajrangCoder commented Dec 21, 2025

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Dec 21, 2025

Summary of Changes

Hello @bajrangCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the addIcon utility by introducing an options parameter, which enables more flexible and theme-adaptive icon management. The primary improvement is the ability to render SVG icons in monochrome, allowing them to inherit the currentColor of their parent element, thus ensuring seamless integration with various UI themes. This change improves the visual consistency and adaptability of icons throughout the application.

Highlights

  • Enhanced addIcon Functionality: The addIcon method now accepts an optional options object, providing more control over how icons are rendered.
  • Monochrome SVG Support: A new monochrome option allows SVG icons to dynamically adapt to the current theme's currentColor using CSS mask-image properties, ensuring better visual integration.
  • Improved Default Icon Styling: The default styling for non-monochrome icons now explicitly sets background-size, background-repeat, and background-position for consistent rendering.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the addIcon function to support monochrome SVG icons that can be colored using currentColor. The implementation is solid, using CSS masks on a ::before pseudo-element for monochrome icons, which is a great approach. I've added a couple of suggestions to use CSS shorthand properties for mask and background, which will make the generated CSS more concise and maintainable. Overall, this is a great enhancement.

Comment thread src/lib/acode.js Outdated
Comment thread src/lib/acode.js Outdated
UnschooledGamer
UnschooledGamer approved these changes Dec 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@UnschooledGamer UnschooledGamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@bajrangCoder bajrangCoder merged commit d3903cd into Acode-Foundation:main Dec 21, 2025
6 checks passed
@bajrangCoder bajrangCoder deleted the svg-icon-bug branch December 21, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UnschooledGamer UnschooledGamer UnschooledGamer approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bajrangCoder @UnschooledGamer