Skip to content

feat(themes): add new premium themes and overhaul legacy ones#1930

Merged
bajrangCoder merged 2 commits intoAcode-Foundation:mainfrom
bajrangCoder:feat/themes-overhaul
Mar 8, 2026
Merged

feat(themes): add new premium themes and overhaul legacy ones#1930
bajrangCoder merged 2 commits intoAcode-Foundation:mainfrom
bajrangCoder:feat/themes-overhaul

Conversation

@bajrangCoder
Copy link
Copy Markdown
Member

Adds 7 new themes and overhauls 6 broken legacy themes for better usability and visual quality.

New Themes

Theme Type Description
Obsidian Dark Luxurious charcoal with rich gold accents
Ember Dark Warm cocoa tones with copper/amber accents
Dusk Dark Deep indigo twilight with violet accents
Carbon Dark Ultra-clean neutral with precise blue accents
Mint Light Fresh and calming with emerald green
Sandstone Light Warm earthy tones with terracotta accents
Blossom Light Soft elegant rose with pink undertones

Redesigned Legacy Themes

Theme What changed
Bump Replaced clashing lavender/gold with cohesive navy + coral palette
Bling Swapped unreadable orange body text for clean light text + emerald accent
Moon Fixed neon cyan body text and invisible teal-on-teal buttons
Atticus Removed random blue/teal clashes, now earthy + sage green
Tomyris Fixed pink/blue text inconsistency, now deep berry + fuchsia
Menes Fixed blue-on-blue invisible buttons, now cool dark + vivid green

Add 7 themes: Obsidian, Ember, Dusk, Carbon, Mint,
   Sandstone, and Blossom — each with unique color identities spanning
   both dark and light variants.

   Redesign 6 legacy themes (Bump, Bling, Moon, Atticus, Tomyris, Menes)
   that had poor contrast, unreadable colored body text, clashing accent
   colors, and missing properties. All now have proper text contrast,
   cohesive palettes, and complete property coverage including
   errorTextColor, dangerColor, scrollbarColor, boxShadowColor, and
   activeTextColor
@github-actions github-actions bot added the enhancement New feature or request label Mar 8, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 8, 2026

Greptile Summary

This PR adds 7 new premium dark/light themes (Obsidian, Ember, Dusk, Carbon, Mint, Sandstone, Blossom) and significantly overhauls 6 legacy themes (Bump, Bling, Moon, Atticus, Tomyris, Menes) to fix readability and palette-coherence issues. All changes are contained in src/theme/preInstalled.js and integrate correctly with the existing ThemeBuilder/createBuiltInTheme infrastructure.

Key observations:

  • All new themes correctly set darkenedPrimaryColor, buttonBackgroundColor/TextColor/ActiveColor, boxShadowColor, activeTextColor, errorTextColor, dangerColor, scrollbarColor, and preferredEditorTheme, aligning them with the more complete theme pattern established by glassDark and sunset.
  • The 6 overhauled legacy themes now include previously-missing fields (boxShadowColor, activeTextColor, errorTextColor, dangerColor, scrollbarColor) and each gains a preferredEditorTheme that was absent before.
  • Dark themes created without an explicit type argument correctly default to "dark" via ThemeBuilder's constructor default, and light themes (Mint, Sandstone, Blossom) correctly pass "light".
  • Contrast concern: The Mint light theme's activeColor (~2.4:1) and linkTextColor (~3.4:1) against its near-white primaryColor background fall short of WCAG AA thresholds (3:1 for UI components, 4.5:1 for normal text). All other light themes in the file (Light, Sunset, Sandstone, Blossom) use darker accent/link hues that comfortably clear these ratios.

Confidence Score: 4/5

  • Safe to merge with one minor accessibility concern in the Mint light theme.
  • The changes are additive and purely cosmetic (CSS variable values). No logic, control flow, or APIs are touched. All new properties map to valid ThemeBuilder setters, and new themes are correctly appended to the export array. The only concern is a WCAG contrast shortfall in mint.activeColor and mint.linkTextColor which affects readability for some users but does not break functionality.
  • src/theme/preInstalled.js — specifically the Mint light theme block (lines 457–478) for the low-contrast active/link colours.

Important Files Changed

Filename Overview
src/theme/preInstalled.js Adds 7 new premium themes and overhauled 6 legacy themes. Changes are structurally sound and follow existing patterns. One contrast issue found in the Mint light theme where the active/link colors fall below WCAG AA requirements against the near-white background.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["createBuiltInTheme(name, type?, version='paid')"]
    A --> B["new ThemeBuilder(name, type='dark', version)"]
    B --> C["autoDarkened = false"]
    C --> D{Theme type?}
    D -- "dark (Obsidian, Ember, Dusk, Carbon, Bump, Bling, Moon, Atticus, Tomyris, Menes)" --> E["Set dark palette properties\n(darkenedPrimaryColor, primaryColor, etc.)"]
    D -- "light (Mint, Sandstone, Blossom)" --> F["Set light palette properties\n(light primaryColor, dark text, etc.)"]
    E --> G["Set shared properties\n(buttonBg/Text/Active, boxShadow,\nactiveText, error, danger, scrollbar)"]
    F --> G
    G --> H["Set preferredEditorTheme\n(one_dark / tokyoNight / monokai / noctisLilac)"]
    H --> I["Export array\n(system, dark, light, ... menes,\nobsidian, ember, dusk, carbon,\nmint, sandstone, blossom, custom)"]
Loading

Last reviewed commit: 0193d97

@bajrangCoder bajrangCoder merged commit fd67733 into Acode-Foundation:main Mar 8, 2026
6 checks passed
@bajrangCoder bajrangCoder deleted the feat/themes-overhaul branch March 8, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant