Commit cffe853
authored
refactor(On-demand-Builds-CI)!: use pull_request_target instead of pull_request. (Acode-Foundation#1628)
* refactor(On-demand-Builds-CI)!: use pull_request_target instead of pull_request.
Important: `pull_request_target` makes the `on-demand-preview-releases-PR.yml` run from base repository with secrets and gives read/write permissions to `$GITHUB_TOKEN` (`secrets.GITHUB_TOKEN`). Unlike normal `pull_request` trigger that has explicit read-ONLY permissions for `$GITHUB_TOKEN`. Meaning secrets and permissions SHOULD BE NOW handled strictly!
Changes:
- checkout `${{ github.event.pull_request.head.sha }}` & sets `persist-credentials: false` to not persist tokens in local git config.
- Adds `skip_tagging_and_releases` input for nightly-build.yml Manual Runs (default: true)
- Adds `CODEOWNERS` file to protect nightly builds and on demand workflows, preventing pushes in PRs without reviews from Authors of the workflow.
* chore: remove `\n\n` from nightly release notes.
* revert(nightly-build): partial file - Acode-Foundation@2c37532
Revert: Acode-Foundation@2c37532
for: Acode-Foundation#1628 (comment) ( @peasneovoyager2banana2) as they did Acode-Foundation#1627 before.
With All Respect!
* add(nightly-build): ref & persist-credentials1 parent 2b5ebcf commit cffe853
File tree
3 files changed
+22
-3
lines changed- .github
- workflows
3 files changed
+22
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
1 | 3 | | |
2 | 4 | | |
3 | 5 | | |
| |||
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
| |||
51 | 59 | | |
52 | 60 | | |
53 | 61 | | |
54 | | - | |
| 62 | + | |
55 | 63 | | |
56 | 64 | | |
57 | 65 | | |
| |||
89 | 97 | | |
90 | 98 | | |
91 | 99 | | |
| 100 | + | |
| 101 | + | |
92 | 102 | | |
93 | 103 | | |
94 | 104 | | |
95 | 105 | | |
96 | 106 | | |
97 | 107 | | |
98 | | - | |
| 108 | + | |
99 | 109 | | |
100 | 110 | | |
101 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
41 | 44 | | |
42 | 45 | | |
43 | 46 | | |
| |||
0 commit comments