Skip to content

Commit 388ca61

Browse files
committed
removed log4j dependencies, old mime type detection library, fixed typo on account header constant
1 parent b6ac7c1 commit 388ca61

6 files changed

Lines changed: 18 additions & 73 deletions

File tree

pom.xml

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</developers>
2424

2525
<properties>
26-
<postmark.version>1.7</postmark.version>
26+
<postmark.version>1.7.2</postmark.version>
2727
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2828
<java.version>1.8</java.version>
2929
<jackson.minimum.version>2.9.7</jackson.minimum.version>
@@ -90,21 +90,9 @@
9090

9191
<!-- MIME auto detect on files -->
9292
<dependency>
93-
<groupId>eu.medsea.mimeutil</groupId>
94-
<artifactId>mime-util</artifactId>
95-
<version>2.1.3</version>
96-
</dependency>
97-
98-
<!-- Logging dependencies -->
99-
<dependency>
100-
<groupId>org.apache.logging.log4j</groupId>
101-
<artifactId>log4j-api</artifactId>
102-
<version>2.9.1</version>
103-
</dependency>
104-
<dependency>
105-
<groupId>org.apache.logging.log4j</groupId>
106-
<artifactId>log4j-core</artifactId>
107-
<version>2.9.1</version>
93+
<groupId>org.apache.tika</groupId>
94+
<artifactId>tika-bundle</artifactId>
95+
<version>1.25</version>
10896
</dependency>
10997

11098
<!-- Testing dependencies -->

src/main/java/com/wildbit/java/postmark/Postmark.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77
import javax.ws.rs.core.MultivaluedMap;
88
import java.io.InputStream;
99
import java.util.Properties;
10+
import java.util.logging.Logger;
1011

11-
import org.apache.logging.log4j.LogManager;
12-
import org.apache.logging.log4j.Logger;
1312
/**
1413
* Top level class allowing simple access to API clients for doing Postmark API calls.
1514
*/
@@ -21,7 +20,7 @@ public class Postmark {
2120
public enum DEFAULTS {
2221
API_URL("api.postmarkapp.com"),
2322
SERVER_AUTH_HEADER("X-Postmark-Server-Token"),
24-
ACOUNT_AUTH_HEADER("X-Postmark-Account-Token");
23+
ACCOUNT_AUTH_HEADER("X-Postmark-Account-Token");
2524

2625
public final String value;
2726

@@ -52,7 +51,7 @@ public static String libraryVersion() {
5251
try {
5352
prop.load(in);
5453
} catch (Exception e) {
55-
log.warn(e.toString());
54+
LOGGER.warning(e.toString());
5655
}
5756
return prop.getProperty("Version");
5857
}
@@ -75,25 +74,25 @@ public static ApiClient getApiClient(String apiToken, Boolean secureConnection,
7574
}
7675

7776
public static AccountApiClient getAccountApiClient(String apiToken) {
78-
return new AccountApiClient(DEFAULTS.API_URL.value, getHeadersWithAuth(DEFAULTS.ACOUNT_AUTH_HEADER, apiToken));
77+
return new AccountApiClient(DEFAULTS.API_URL.value, getHeadersWithAuth(DEFAULTS.ACCOUNT_AUTH_HEADER, apiToken));
7978
}
8079

8180
public static AccountApiClient getAccountApiClient(String apiToken, Boolean secureConnection) {
82-
return new AccountApiClient(DEFAULTS.API_URL.value, getHeadersWithAuth(DEFAULTS.ACOUNT_AUTH_HEADER, apiToken), secureConnection);
81+
return new AccountApiClient(DEFAULTS.API_URL.value, getHeadersWithAuth(DEFAULTS.ACCOUNT_AUTH_HEADER, apiToken), secureConnection);
8382
}
8483

8584
/**
8685
* In rare cases, other than default API url might need to be used, mainly for testing purposes.
8786
*/
8887
public static AccountApiClient getAccountApiClient(String apiToken, Boolean secureConnection, String customApiUrl) {
89-
return new AccountApiClient(customApiUrl, getHeadersWithAuth(DEFAULTS.ACOUNT_AUTH_HEADER, apiToken), secureConnection);
88+
return new AccountApiClient(customApiUrl, getHeadersWithAuth(DEFAULTS.ACCOUNT_AUTH_HEADER, apiToken), secureConnection);
9089
}
9190

9291
// private methods
9392

9493
private Postmark() {}
9594

96-
private static Logger log = LogManager.getLogger(Postmark.class);
95+
private final static Logger LOGGER = Logger.getLogger(Postmark.class.getName());
9796

9897
private static MultivaluedMap<String,Object> getHeadersWithAuth(DEFAULTS authType, String apiToken) {
9998
MultivaluedMap headers = DefaultHeaders.headers();

src/main/java/com/wildbit/java/postmark/client/HttpClientHandler.java

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@
22

33
import com.wildbit.java.postmark.client.data.DataHandler;
44
import com.wildbit.java.postmark.client.exception.*;
5-
import org.apache.logging.log4j.LogManager;
6-
import org.apache.logging.log4j.Level;
7-
import org.apache.logging.log4j.core.LoggerContext;
8-
import org.apache.logging.log4j.core.config.Configuration;
9-
import org.apache.logging.log4j.core.config.LoggerConfig;
105

116
import javax.ws.rs.core.MultivaluedMap;
127
import java.io.IOException;
@@ -76,27 +71,12 @@ protected String execute(HttpClient.REQUEST_TYPES request_type, String url, Obje
7671

7772
/**
7873
* Main source of issues can be the Object serialization process. To debug it, this method will set strict mapping, which
79-
* will fail on any issues. Also by choosing debug mode, logging will be set to DEBUG level
74+
* will fail on any issues.
8075
*/
8176
public void setDebugMode() {
82-
setLoggingLevel(Level.DEBUG);
8377
this.dataHandler.setStrictMapper();
8478
}
8579

86-
/**
87-
* Custom level of logging can be set.
88-
*
89-
* @param level - debugging level - OFF, DEBUG, ERROR etc.
90-
*/
91-
public void setLoggingLevel(Level level) {
92-
LoggerContext ctx = (LoggerContext) LogManager.getContext(false);
93-
Configuration config = ctx.getConfiguration();
94-
95-
LoggerConfig loggerConfig = config.getLoggerConfig(LogManager.ROOT_LOGGER_NAME);
96-
loggerConfig.setLevel(level);
97-
ctx.updateLoggers();
98-
}
99-
10080
public void setSecureConnection(boolean secureConnection) {
10181
this.secureConnection = secureConnection;
10282
}

src/main/java/com/wildbit/java/postmark/client/data/model/message/BaseMessage.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
import java.nio.file.Files;
66
import java.nio.file.Paths;
77
import java.util.*;
8-
9-
import eu.medsea.mimeutil.MimeUtil;
8+
import org.apache.tika.Tika;
109

1110
/**
1211
* Base email message object
@@ -333,10 +332,8 @@ private byte[] readFileContent(String path) throws IOException {
333332
return Files.readAllBytes(Paths.get(path));
334333
}
335334

336-
private String readFileContentType(String path) {
337-
File file = new File(path);
338-
MimeUtil.registerMimeDetector("eu.medsea.mimeutil.detector.MagicMimeMimeDetector");
339-
return MimeUtil.getMimeTypes(file).toString();
335+
private String readFileContentType(String path) throws IOException {
336+
return new Tika().detect(new File(path));
340337
}
341338

342339
/**

src/main/java/com/wildbit/java/postmark/client/data/model/templates/BaseTemplatedMessage.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.wildbit.java.postmark.client.data.model.templates;
22

33
import com.wildbit.java.postmark.client.data.model.message.Header;
4-
import eu.medsea.mimeutil.MimeUtil;
4+
import org.apache.tika.Tika;
55

66
import java.io.File;
77
import java.io.IOException;
@@ -316,10 +316,8 @@ private byte[] readFileContent(String path) throws IOException {
316316
return Files.readAllBytes(Paths.get(path));
317317
}
318318

319-
private String readFileContentType(String path) {
320-
File file = new File(path);
321-
MimeUtil.registerMimeDetector("eu.medsea.mimeutil.detector.MagicMimeMimeDetector");
322-
return MimeUtil.getMimeTypes(file).toString();
319+
private String readFileContentType(String path) throws IOException {
320+
return new Tika().detect(new File(path));
323321
}
324322

325323
/**

src/main/resources/log4j2.properties

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)