Skip to content

Fix: Make header sticky on desktop. #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oscarmuya wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix: Make header sticky on desktop. #848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Header.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export default {
return {
activityViews: null,
// Make configurable?
fixedTopMenu: this.$isAndroid,
fixedTopMenu: true,
Comment on lines 139 to +140
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The comment // Make configurable? is now stale — the value is unconditionally true and no longer derived from any condition, so the question of configurability is less relevant. Consider removing or updating the comment to reflect the intent.

Suggested change
// Make configurable?
fixedTopMenu: this.$isAndroid,
fixedTopMenu: true,
fixedTopMenu: true,

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

};
},
computed: {
Expand Down
Loading