AC-357430: update of the commerce connector project

k-s-popova · k-s-popova · commit 2785310114f7 · 2026-03-10T17:25:15.000+01:00
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/BCBindingWooCommerce.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/BCBindingWooCommerce.cs
@@ -30,39 +30,39 @@ public abstract class bindingID :
         [PXDBString(50, IsUnicode = true, InputMask = "")]
         [PXUIField(DisplayName = "API Path")]
         [PXDefault()]
-        public virtual string StoreBaseUrl { get; set; }
+        public virtual string? StoreBaseUrl { get; set; }
         public abstract class storeBaseUrl : 
             PX.Data.BQL.BqlString.Field<storeBaseUrl> { }
         #endregion
         #region StoreXAuthClient
         [PXRSACryptString(IsUnicode = true, InputMask = "")]
         [PXUIField(DisplayName = "Consumer Key")]
         [PXDefault()]
-        public virtual string StoreXAuthClient { get; set; }
+        public virtual string? StoreXAuthClient { get; set; }
         public abstract class storeXAuthClient : 
             PX.Data.BQL.BqlString.Field<storeXAuthClient> { }
         #endregion
         #region StoreXAuthToken
         [PXRSACryptString(IsUnicode = true, InputMask = "")]
         [PXUIField(DisplayName = "Consumer Secret")]
         [PXDefault()]
-        public virtual string StoreXAuthToken { get; set; }
+        public virtual string? StoreXAuthToken { get; set; }
         public abstract class storeXAuthToken : 
             PX.Data.BQL.BqlString.Field<storeXAuthToken> { }
         #endregion
 
         #region WooCommerceDefaultCurrency
         [PXDBString(12, IsUnicode = true)]
         [PXUIField(DisplayName = "Default Currency", IsReadOnly = true)]
-        public virtual string WooCommerceDefaultCurrency { get; set; }
+        public virtual string? WooCommerceDefaultCurrency { get; set; }
         public abstract class wooCommerceDefaultCurrency : 
             PX.Data.BQL.BqlString.Field<wooCommerceDefaultCurrency> { }
         #endregion
 
         #region WooCommerceStoreTimeZone 
         [PXDBString(100, IsUnicode = true)]
         [PXUIField(DisplayName = "Store Time Zone", IsReadOnly = true)]
-        public virtual string WooCommerceStoreTimeZone { get; set; }
+        public virtual string? WooCommerceStoreTimeZone { get; set; }
         public abstract class wooCommerceStoreTimeZone : 
             PX.Data.BQL.BqlString.Field<wooCommerceStoreTimeZone> { }
         #endregion
@@ -71,7 +71,7 @@ public abstract class wooCommerceStoreTimeZone :
         [PXDBString(100, IsUnicode = true, InputMask = "")]
         [PXUIField(DisplayName = "Store Admin Path")]
         [PXDefault()]
-        public virtual string StoreAdminUrl { get; set; }
+        public virtual string? StoreAdminUrl { get; set; }
         public abstract class storeAdminUrl : 
             PX.Data.BQL.BqlString.Field<storeAdminUrl> { }
         #endregion
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/External/CustomerAddressData.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/External/CustomerAddressData.cs
@@ -14,54 +14,52 @@ public class CustomerAddressData : BCAPIEntity, IEquatable<CustomerAddressData>
         [JsonProperty("first_name")]
         [CommerceDescription(WCCaptions.FirstName, FieldFilterStatus.Skipped, FieldMappingStatus.Import)]
         [ValidateRequired()]
-        public virtual string FirstName { get; set; }
+        public virtual string? FirstName { get; set; }
 
         [JsonProperty("last_name")]
         [CommerceDescription(WCCaptions.LastName, FieldFilterStatus.Skipped, FieldMappingStatus.Import)]
-        public virtual string LastName { get; set; }
-
+        public virtual string? LastName { get; set; }
         [JsonProperty("company")]
         [CommerceDescription(WCCaptions.CompanyName, FieldFilterStatus.Skipped, FieldMappingStatus.Import)]
-        public virtual string Company { get; set; }
+        public virtual string? Company { get; set; }
 
         [JsonProperty("address_1")]
         [CommerceDescription(WCCaptions.AddressLine1, FieldFilterStatus.Skipped, FieldMappingStatus.Import)]
         [ValidateRequired(AutoDefault = true)]
-        public string Address1 { get; set; }
+        public string? Address1 { get; set; }
 
         [JsonProperty("address_2")]
         [CommerceDescription(WCCaptions.AddressLine2, FieldFilterStatus.Skipped, FieldMappingStatus.Import)]
-        public string Address2 { get; set; }
-
+        public string? Address2 { get; set; }
         [JsonProperty("city")]
         [CommerceDescription(WCCaptions.City, FieldFilterStatus.Skipped, FieldMappingStatus.Import)]
         [ValidateRequired(AutoDefault = true)]
-        public virtual string City { get; set; }
+        public virtual string? City { get; set; }
 
         [JsonProperty("postcode")]
         [CommerceDescription(WCCaptions.PostalCode, FieldFilterStatus.Skipped, FieldMappingStatus.Import)]
         [ValidateRequired(AutoDefault = true)]
-        public virtual string PostalCode { get; set; }
+        public virtual string? PostalCode { get; set; }
 
         [JsonProperty("country")]
         [CommerceDescription(WCCaptions.Country, FieldFilterStatus.Skipped, FieldMappingStatus.Import)]
         [ValidateRequired()]
-        public virtual string Country { get; set; }
+        public virtual string? Country { get; set; }
 
         [JsonProperty("state")]
         [Description(WCCaptions.State)]
         [ValidateRequired(AutoDefault = true)]
-        public virtual string State { get; set; }
+        public virtual string? State { get; set; }
 
         [JsonProperty("phone")]
         [Description(WCCaptions.Phone)]
         [ValidateRequired(AutoDefault = true)]
-        public virtual string Phone { get; set; }
+        public virtual string? Phone { get; set; }
 
         [JsonProperty("email")]
         [Description(WCCaptions.Email)]
         [ValidateRequired(AutoDefault = true)]
-        public virtual string Email { get; set; }
+        public virtual string? Email { get; set; }
 
         public bool Equals(CustomerAddressData newObject)
         {
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/External/CustomerData.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/External/CustomerData.cs
@@ -23,7 +23,7 @@ public virtual DateTime? CreatedDateTime
             get
             {
                 return DateCreatedUT != null ? 
-                    (DateTime)DateCreatedUT.ToDate() : default;
+                    DateCreatedUT.ToDate() : default;
             }
         }
 
@@ -37,37 +37,37 @@ public virtual DateTime? ModifiedDateTime
             get
             {
                 return DateModified != null ? 
-                    (DateTime)DateModified.ToDate() : default;
+                    DateModified.ToDate() : default;
             }
         }
 
         [JsonProperty("email")]
         [CommerceDescription(WCCaptions.Email, FieldFilterStatus.Skipped, 
             FieldMappingStatus.Import)]
         [ValidateRequired]
-        public string Email { get; set; }
+        public string? Email { get; set; }
 
         [JsonProperty("first_name")]
         [CommerceDescription(WCCaptions.FirstName, FieldFilterStatus.Skipped, 
             FieldMappingStatus.Import)]
         [ValidateRequired]
-        public string FirstName { get; set; }
+        public string? FirstName { get; set; }
 
         [JsonProperty("last_name")]
         [CommerceDescription(WCCaptions.LastName, FieldFilterStatus.Skipped, 
             FieldMappingStatus.Import)]
         [ValidateRequired()]
-        public string LastName { get; set; }
+        public string? LastName { get; set; }
 
         [JsonProperty("username")]
         [CommerceDescription(WCCaptions.UserName, FieldFilterStatus.Skipped, 
             FieldMappingStatus.Import)]
-        public string Username { get; set; }
+        public string? Username { get; set; }
 
         [JsonProperty("billing")]
-        public CustomerAddressData Billing { get; set; }
+        public CustomerAddressData? Billing { get; set; }
 
         [JsonProperty("shipping")]
-        public CustomerAddressData Shipping { get; set; }
+        public CustomerAddressData? Shipping { get; set; }
     }
 }
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/External/WooRestClientBase.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/External/WooRestClientBase.cs
@@ -2,9 +2,7 @@
 using PX.Commerce.Core;
 using PX.Data;
 using System;
-using System.Collections.Generic;
 using System.Linq;
-using System.Text;
 using System.Threading.Tasks;
 using PX.Commerce.Core.REST;
 using Polly;
@@ -23,7 +21,7 @@ protected WooRestClientBase(int attempts) : base(attempts)
         protected override ValueTask<bool> IsFailure(Outcome<HttpCallContext> result,
             int attemptNumber, int attempts) =>
             new((result.Exception is not null
-                || (int)result.Result.Response.StatusCode is 429)
+                || (result.Result?.Response is not null && (int)result.Result.Response.StatusCode == 429))
                 && attempts >= attemptNumber);
 
         protected override ValueTask HandleError(HttpCallContext ctx,
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/Internal/Case.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/Internal/Case.cs
@@ -5,16 +5,16 @@
 [CommerceDescription("Case")]
 public partial class Case : CBAPIEntity
 {
-	public GuidValue NoteID { get; set; }
+	public GuidValue? NoteID { get; set; }
 
-	public DateTimeValue LastModifiedDateTime { get; set; }
+	public DateTimeValue? LastModifiedDateTime { get; set; }
 
 	[CommerceDescription("CaseCD")]
-	public StringValue CaseCD { get; set; }
+	public StringValue? CaseCD { get; set; }
 
 	[CommerceDescription("Subject")]
-	public StringValue Subject { get; set; }
+	public StringValue? Subject { get; set; }
 
 	[CommerceDescription("Description")]
-	public StringValue Description { get; set; }
+	public StringValue? Description { get; set; }
 }
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/Sync/WooCustomerEntityBucket.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/Sync/WooCustomerEntityBucket.cs
@@ -8,6 +8,6 @@ public class WooCustomerEntityBucket : EntityBucketBase, IEntityBucket
         public IMappedEntity Primary => Customer;
         public IMappedEntity[] Entities => new IMappedEntity[] { Customer };
 
-        public MappedCustomer Customer;
+        public MappedCustomer Customer = null!;
     }
 }
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/Sync/WooCustomerProcessor.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/Sync/WooCustomerProcessor.cs
@@ -43,8 +43,8 @@ public class WooCustomerProcessor :
         BCProcessorSingleBase<WooCustomerProcessor, 
             WooCustomerEntityBucket, MappedCustomer>, IProcessor
     {
-        public RestClient client;
-        protected CustomerDataProvider customerDataProvider;
+        public RestClient client = null!;
+        protected CustomerDataProvider customerDataProvider = null!;
 
         //protected List<Country> countries;
         public CommerceHelper helper = 
@@ -126,8 +126,8 @@ public virtual Contact SetBillingContact(CustomerData customerObj)
             .ValueField();
             contactImpl.FirstName = customerObj.Billing?.FirstName
             .ValueField();
-            contactImpl.LastName = customerObj.Billing.LastName.ValueField();
-            contactImpl.Email = customerObj.Billing.Email.ValueField();
+            contactImpl.LastName = customerObj.Billing?.LastName?.ValueField();
+            contactImpl.Email = customerObj.Billing?.Email?.ValueField();
             contactImpl.Address = MapAddress(customerObj.Billing);
             contactImpl.Active = true.ValueField();
             contactImpl.Phone1 = customerObj.Billing?.Phone.ValueField();
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/Sync/WooLocationEntityBucket.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/Sync/WooLocationEntityBucket.cs
@@ -12,7 +12,7 @@ public class WooLocationEntityBucket : EntityBucketBase, IEntityBucket
         public override IMappedEntity[] PostProcessors =>
           new IMappedEntity[] { Customer };
 
-        public MappedLocation Address;
-        public MappedCustomer Customer;
+        public MappedLocation Address = null!;
+        public MappedCustomer Customer = null!;
     }
 }
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/WooCommerceConnector.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/WooCommerceConnector.cs
@@ -1,17 +1,19 @@
 ﻿using Newtonsoft.Json;
-using System;
+using PX.Async;
+using PX.Commerce.BigCommerce;
 using PX.Commerce.BigCommerce.API.REST;
-using PX.Commerce.Core.REST;
 using PX.Commerce.Core;
+using PX.Commerce.Core.REST;
+using PX.Common;
+using PX.Data;
 using PX.Data.BQL;
-using PX.Async;
+using RestSharp;
+using System;
 using System.Collections.Generic;
-using PX.Common;
 using System.Linq;
-using PX.Data;
-using System.Threading.Tasks;
+using System.Text.RegularExpressions;
 using System.Threading;
-using RestSharp;
+using System.Threading.Tasks;
 
 namespace WooCommerceTest
 {
@@ -29,7 +31,7 @@ public WCConnectorType() : base(TYPE) { }
         public override string ConnectorName { get => NAME; }
 
         public override void NavigateExtern(ISyncStatus status, 
-            ISyncDetail detail = null)
+            ISyncDetail detail)
         {
             if (status?.ExternID == null) return;
 
@@ -52,7 +54,7 @@ public override void NavigateExtern(ISyncStatus status,
         }
 
         public override async Task<ConnectorOperationResult> Process(
-            ConnectorOperation operation, int?[] syncIDs = null,
+            ConnectorOperation operation, int?[] syncIDs,
             CancellationToken cancellationToken = default)
         {
             EntityInfo info = GetEntities().FirstOrDefault(e => 
@@ -86,18 +88,20 @@ public override async Task ProcessHook(
 
         public static RestClient GetRestClient(BCBindingWooCommerce binding)
         {
-            return GetRestClient(binding.StoreBaseUrl, 
-                binding.StoreXAuthClient, binding.StoreXAuthToken);
+            Dictionary<string, string> authHeaders = new()
+            {
+                { BigCommerceConstants.Headers.AuthToken, binding.StoreXAuthToken },
+                { BigCommerceConstants.Headers.AuthClient, binding.StoreXAuthClient }
+            };
+            return CreateClient(binding.StoreBaseUrl, authHeaders);
         }
 
-        public static RestClient GetRestClient(String url, String clientID, 
-            String token)
+        public static RestClient CreateClient(string baseUri, Dictionary<string, string> authHeaders)
         {
             RestOptions options = new RestOptions
             {
-                BaseUri = url,
-                XAuthClient = clientID,
-                XAuthTocken = token
+                BaseUri = baseUri,
+                AuthHeaders = authHeaders
             };
             JsonSerializerSettings serializer = new JsonSerializerSettings
             {
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/WooCommerceStoreMaint.cs b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/WooCommerceStoreMaint.cs
@@ -12,15 +12,15 @@ public class WooCommerceStoreMaint : BCStoreMaint
 
         public SelectFrom<BCBindingWooCommerce>.
             Where<BCBindingWooCommerce.bindingID.
-                IsEqual<BCBinding.bindingID.FromCurrent>>.View CurrentBindingWooCommerce;
+                IsEqual<BCBinding.bindingID.FromCurrent>>.View CurrentBindingWooCommerce = null!;
 
         public WooCommerceStoreMaint()
         {
             base.Bindings.WhereAnd<Where<BCBinding.connectorType.IsEqual<WooCommerceConnector.WCConnectorType>>>();
         }
 
         #region Actions
-        public PXAction<BCBinding> TestConnection;
+        public PXAction<BCBinding> TestConnection = null!;
         [PXButton]
         [PXUIField(DisplayName = "Test Connection", Enabled = false)]
         protected virtual IEnumerable testConnection(PXAdapter adapter)
@@ -44,15 +44,15 @@ protected virtual IEnumerable testConnection(PXAdapter adapter)
         #endregion
 
         [PXMergeAttributes(Method = MergeMethod.Append)]
-        [PXCustomizeBaseAttribute(typeof(BCConnectorsAttribute), "DefaultConnector", WooCommerceConnector.TYPE)]
+        [PXCustomize.AnyAttribute(typeof(BCConnectorsAttribute),
+            nameof(BCConnectorsAttribute.DefaultConnector), WooCommerceConnector.TYPE)]
         public virtual void _(Events.CacheAttached<BCBinding.connectorType> e) { }
 
         public override void _(Events.RowSelected<BCBinding> e)
         {
             base._(e);
-
+            if (e.Row == null) return;
             BCBinding row = e.Row as BCBinding;
-            if (row == null) return;
 
             //Actions
             TestConnection.SetEnabled(row.BindingID > 0 && row.ConnectorType == WooCommerceConnector.TYPE);
@@ -71,8 +71,8 @@ public override void _(Events.RowSelected<BCBindingExt> e)
         {
             base._(e);
 
+            if (e.Row == null) return;
             BCBindingExt row = e.Row as BCBindingExt;
-            if (row == null) return;
             PXDefaultAttribute.SetPersistingCheck<BCBindingExt.refundAmountItemID>(e.Cache, row, PXPersistingCheck.Nothing);
         }
 
diff --git a/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/WooCommerceTest.csproj b/PlugInDevelopment/Help/ImplementingConnector/WooCommerceTest/WooCommerceTest.csproj
@@ -10,7 +10,7 @@
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
     <FileVersion>25.201.0166</FileVersion>
     <InformationalVersion>25.201.0166</InformationalVersion>
-    <LangVersion>9.0</LangVersion>
+    <LangVersion>12.0</LangVersion>
     <Nullable>enable</Nullable>
     <Copyright>Copyright © 2005-2025 Acumatica, Inc. All rights reserved.</Copyright>
   </PropertyGroup>
@@ -72,10 +72,6 @@
       <SpecificVersion>False</SpecificVersion>
       <HintPath>..\..\..\..\Bin\Serilog.dll</HintPath>
     </Reference>
-    <Reference Include="System.Threading.Tasks.Extensions, Version=4.2.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
-      <SpecificVersion>False</SpecificVersion>
-      <HintPath>..\..\..\..\Bin\System.Threading.Tasks.Extensions.dll</HintPath>
-    </Reference>
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.Bcl.AsyncInterfaces">

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,6 @@ public class WooCustomerEntityBucket : EntityBucketBase, IEntityBucket`
`8`	`8`	`public IMappedEntity Primary => Customer;`
`9`	`9`	`public IMappedEntity[] Entities => new IMappedEntity[] { Customer };`
`10`	`10`
`11`		`- public MappedCustomer Customer;`
	`11`	`+ public MappedCustomer Customer = null!;`
`12`	`12`	`}`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public class WooLocationEntityBucket : EntityBucketBase, IEntityBucket`
`12`	`12`	`public override IMappedEntity[] PostProcessors =>`
`13`	`13`	`new IMappedEntity[] { Customer };`
`14`	`14`
`15`		`- public MappedLocation Address;`
`16`		`- public MappedCustomer Customer;`
	`15`	`+ public MappedLocation Address = null!;`
	`16`	`+ public MappedCustomer Customer = null!;`
`17`	`17`	`}`
`18`	`18`	`}`