Skip to content

Commit b67eada

Browse files
authored
Merge pull request #175 from Acumatica/feature/EDU-9616-2026R1-T250-Course-Update-Code-Snippets
EDU-9429: Fixed the errors raised by Acuminator in graph and DAC
2 parents 1ea1e28 + 8c4bddd commit b67eada

13 files changed

Lines changed: 21 additions & 21 deletions

File tree

Customization/T250/CodeSnippets/Activity1.1.1/Step3/RSSVPaymentPlanInq.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
3131
if (e.Row == null) return;
3232
if (e.Row.OrderTotal == 0) return;
3333
RSSVWorkOrderToPay order = e.Row;
34-
// Acuminator disable once PX1042 DatabaseQueriesInRowSelecting [Justification]
3534
var invoices =
3635
SelectFrom<ARInvoice>.
3736
Where<ARInvoice.refNbr.IsEqual<@P.AsString>>.

Customization/T250/CodeSnippets/Activity1.1.1/Step4/RSSVPaymentPlanInq.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
2626
if (e.Row == null) return;
2727
if (e.Row.OrderTotal == 0) return;
2828
RSSVWorkOrderToPay order = e.Row;
29-
// Acuminator disable once PX1042 DatabaseQueriesInRowSelecting [Justification]
3029
var invoices =
3130
SelectFrom<ARInvoice>.
3231
Where<ARInvoice.refNbr.IsEqual<@P.AsString>>.

Customization/T250/CodeSnippets/Activity1.2.1/Step1/RSSVPaymentPlanInq.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
2323
if (e.Row == null) return;
2424
if (e.Row.OrderTotal == 0) return;
2525
RSSVWorkOrderToPay order = e.Row;
26-
// Acuminator disable once PX1042 DatabaseQueriesInRowSelecting [Justification]
2726
var invoices =
2827
SelectFrom<ARInvoice>.
2928
Where<ARInvoice.refNbr.IsEqual<@P.AsString>>.
@@ -39,6 +38,7 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
3938

4039
////////// The added code
4140
[PXHidden]
41+
[PXVirtual]
4242
public class RSSVWorkOrderToPayFilter : PXBqlTable, IBqlTable
4343
{
4444
#region CustomerID

Customization/T250/CodeSnippets/Activity1.2.1/Step2/RSSVPaymentPlanInq.cs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
3939
if (e.Row == null) return;
4040
if (e.Row.OrderTotal == 0) return;
4141
RSSVWorkOrderToPay order = e.Row;
42-
// Acuminator disable once PX1042 DatabaseQueriesInRowSelecting [Justification]
4342
var invoices =
4443
SelectFrom<ARInvoice>.
4544
Where<ARInvoice.refNbr.IsEqual<@P.AsString>>.
@@ -54,8 +53,18 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
5453
}
5554

5655
[PXHidden]
56+
[PXVirtual]
5757
public class RSSVWorkOrderToPayFilter : PXBqlTable, IBqlTable
5858
{
59+
60+
#region CustomerID
61+
[CustomerActive(DisplayName = "Customer ID")]
62+
public virtual int? CustomerID { get; set; }
63+
public abstract class customerID :
64+
PX.Data.BQL.BqlInt.Field<customerID>
65+
{ }
66+
#endregion
67+
5968
#region ServiceID
6069
[PXInt()]
6170
[PXUIField(DisplayName = "Service")]
@@ -71,12 +80,5 @@ public abstract class serviceID :
7180
{ }
7281
#endregion
7382

74-
#region CustomerID
75-
[CustomerActive(DisplayName = "Customer ID")]
76-
public virtual int? CustomerID { get; set; }
77-
public abstract class customerID :
78-
PX.Data.BQL.BqlInt.Field<customerID>
79-
{ }
80-
#endregion
8183
}
8284
}

Customization/T250/CodeSnippets/Activity1.3.1/Step1/RSSVWorkOrder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ public abstract class percentPaid :
299299
})]
300300
public virtual string? OrderType { get; set; }
301301
public abstract class orderType :
302-
PX.Data.BQL.BqlDecimal.Field<orderType>
302+
PX.Data.BQL.BqlString.Field<orderType>
303303
{ }
304304
#endregion
305305
////////// The end of added code

Customization/T250/CodeSnippets/Activity1.3.1/Step2/RSSVPaymentPlanInq.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
9595
if (e.Row == null) return;
9696
if (e.Row.OrderTotal == 0) return;
9797
RSSVWorkOrderToPay order = e.Row;
98-
// Acuminator disable once PX1042 DatabaseQueriesInRowSelecting [Justification]
9998
var invoices =
10099
SelectFrom<ARInvoice>.
101100
Where<ARInvoice.refNbr.IsEqual<@P.AsString>>.
@@ -120,6 +119,7 @@ public static RSSVWorkOrderToPay ToRSSVWorkOrderToPay
120119
}
121120

122121
[PXHidden]
122+
[PXVirtual]
123123
public class RSSVWorkOrderToPayFilter : PXBqlTable, IBqlTable
124124
{
125125
#region ServiceID

Customization/T250/CodeSnippets/Activity1.4.1/Step1/RSSVPaymentPlanInq.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
7878
if (e.Row == null) return;
7979
if (e.Row.OrderTotal == 0) return;
8080
RSSVWorkOrderToPay order = e.Row;
81-
// Acuminator disable once PX1042 DatabaseQueriesInRowSelecting [Justification]
8281
var invoices =
8382
SelectFrom<ARInvoice>.
8483
Where<ARInvoice.refNbr.IsEqual<@P.AsString>>.
@@ -101,6 +100,7 @@ public static RSSVWorkOrderToPay ToRSSVWorkOrderToPay
101100
}
102101

103102
[PXHidden]
103+
[PXVirtual]
104104
public class RSSVWorkOrderToPayFilter : PXBqlTable, IBqlTable
105105
{
106106
#region ServiceID

Customization/T250/CodeSnippets/Activity1.4.1/Step3/RSSVPaymentPlanInq.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ protected virtual IEnumerable detailsView()
4242
SelectFrom<RSSVWorkOrderToPay>.
4343
InnerJoin<ARInvoice>.On<
4444
ARInvoice.refNbr.IsEqual<RSSVWorkOrderToPay.invoiceNbr>>.
45-
Where<
46-
RSSVWorkOrderToPay.status.IsNotEqual<RSSVWorkOrderEntry_Workflow.States.paid>.
45+
Where<RSSVWorkOrderToPay.status.
46+
IsNotEqual<RSSVWorkOrderEntry_Workflow.States.paid>.
4747
And<RSSVWorkOrderToPayFilter.customerID.FromCurrent.IsNull.
4848
Or<RSSVWorkOrderToPay.customerID.IsEqual<
4949
RSSVWorkOrderToPayFilter.customerID.FromCurrent>>>.
@@ -111,7 +111,6 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
111111
if (e.Row == null) return;
112112
if (e.Row.OrderTotal == 0) return;
113113
RSSVWorkOrderToPay order = e.Row;
114-
// Acuminator disable once PX1042 DatabaseQueriesInRowSelecting [Justification]
115114
var invoices =
116115
SelectFrom<ARInvoice>.
117116
Where<ARInvoice.refNbr.IsEqual<@P.AsString>>.
@@ -134,6 +133,7 @@ public static RSSVWorkOrderToPay ToRSSVWorkOrderToPay
134133
}
135134

136135
[PXHidden]
136+
[PXVirtual]
137137
public class RSSVWorkOrderToPayFilter : PXBqlTable, IBqlTable
138138
{
139139
#region ServiceID

Customization/T250/CodeSnippets/Activity1.5.1/Step1/RSSVWorkOrder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ public abstract class percentPaid :
306306
})]
307307
public virtual string? OrderType { get; set; }
308308
public abstract class orderType :
309-
PX.Data.BQL.BqlDecimal.Field<orderType>
309+
PX.Data.BQL.BqlString.Field<orderType>
310310
{ }
311311
#endregion
312312

Customization/T250/CodeSnippets/Activity1.5.2/Step1/RSSVPaymentPlanInq.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ protected virtual void _(Events.RowSelecting<RSSVWorkOrderToPay> e)
153153
if (e.Row == null) return;
154154
if (e.Row.OrderTotal == 0) return;
155155
RSSVWorkOrderToPay order = e.Row;
156-
// Acuminator disable once PX1042 DatabaseQueriesInRowSelecting [Justification]
157156
var invoices =
158157
SelectFrom<ARInvoice>.
159158
Where<ARInvoice.refNbr.IsEqual<@P.AsString>>.
@@ -176,6 +175,7 @@ public static RSSVWorkOrderToPay ToRSSVWorkOrderToPay
176175
}
177176

178177
[PXHidden]
178+
[PXVirtual]
179179
public class RSSVWorkOrderToPayFilter : PXBqlTable, IBqlTable
180180
{
181181
#region ServiceID

0 commit comments

Comments
 (0)