Conversation
|
|
jklmnn
force-pushed
the
issue-466
branch
4 times, most recently
from
0349420 to
d6e3d70
Compare
|
Hello Johannes,
On 08-Apr-26 9:19 AM, JK wrote:
The definition of Serial_Port uses the aspect Interrupt_Priority taking
a value from the specified discriminants. However the discriminant is
not visible in this scope. Use a pragma in the definition of the type
instead where the discriminant is visible.
ref #466 <#466>
I believe that's a regression in the compiler, unless there has been a
decision by the ARG. One of the releases of the compiler rejected it in
the now-distant past but later compilers accepted it. I have used that
idiom many times successfully, so unless there has been a recent ruling
against it, it should still be legit. Has something changed?
Thanks,
Pat
|
Member
Author
|
Ah, thanks for the heads-up. I will see if I can reproduce the internally and open an issue for that, or if it can be fixed with a newer FSF GNAT build. If we can't immediately fix it here, I'd still go for the current workaround (and add a comment) to have at least the CI working again so we have some testing for the other PRs. |
|
Agreed. |
The definition of Serial_Port uses the aspect Interrupt_Priority taking a value from the specified discriminants. However the discriminant is not visible in this scope. Use a pragma in the definition of the type instead where the discriminant is visible. ref #466
The function distutils.spawn.find_executable is deprecated and should be replaced with shutil.which. Distutils itself is also no longer part of the standard library as of Python 3.12. ref #466
Member
Author
|
@pat-rogers can you rebase your PRs and see if the CI is fixed in them? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definition of Serial_Port uses the aspect Interrupt_Priority taking a value from the specified discriminants. However the discriminant is not visible in this scope. Use a pragma in the definition of the type instead where the discriminant is visible.
ref #466