fix(ogar-vocab): clear pre-existing clippy debt (derivable Default, doc/attr nits)

ogar-vocab has never been workspace-clippy-gated — the same surrealdb-ast
403 root cause that blocks the whole OGAR workspace from resolving
in-sandbox also meant 'cargo clippy --workspace' has never run here. The
probe workspace used to verify compile_graph_ruby (PR #144) made this
debt visible for the first time. Mechanical fixes only, no behavior
change:

- 9 manual impl Default blocks (MethodKind/RecordSemantics/
  GuardFailurePolicy/ActionSubject/TemporalSpec/ModalSpec/ActionState/
  AssociationKind/Language) replaced with #[derive(Default)] +
  #[default] on the already-documented default variant
  (clippy::derivable_impls). Language's impl lived at the very end of
  the file, after #[cfg(test)] mod tests — also tripped
  items_after_test_module; moving the derive to the enum's declaration
  (already well before the test module) fixes both at once.
- One blank line between #[non_exhaustive] and the ActionDef struct
  declaration removed (clippy::empty_line_after_outer_attr).
- Two doc-comment lines re-indented to read as a paragraph continuation
  rather than an unindented markdown list item — the actual cause is a
  '+' at the start of a wrapped sentence ('... seeds X + BillingCore
  (0x61); ...') being parsed as a list bullet by rustdoc's CommonMark
  parser (clippy::doc_lazy_continuation).

Verification (same probe workspace as PR #144's compile_graph_ruby):
clippy -D warnings clean for ogar-vocab AND the full probe workspace
(both crates) at the pinned 1.95.0 toolchain; 95/95 ogar-vocab unit
tests + 2/3 doctests (1 pre-existing #[ignore]) pass; 44/44
ogar-from-ruff tests still pass (Class.language construction
unaffected — Default::default() now resolves through the derive instead
of the manual impl, same value). cargo fmt --check clean.

Author: claude

crates/ogar-vocab/src/lib.rs

@@ -38,11 +38,12 @@ use serde::{Deserialize, Serialize};
 /// `pub enum` / `pub struct` in this module: the OGAR vocabulary is
 /// expected to evolve over time, and every base type is forward-
 /// compatible-by-construction.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum Language {
     /// Ruby ActiveRecord (`class Foo < ApplicationRecord`).
+    #[default]
     Ruby,
     /// Python — covers Django ORM and Odoo `models.Model`.
     Python,
@@ -305,7 +306,7 @@ pub struct MethodDecl {
 /// Method kind — distinguishes overrides from helpers from plain
 /// methods. The producer determines kind from decorator + name
 /// inspection; see `docs/ODOO-TRANSCODING.md` §13.
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum MethodKind {
@@ -318,37 +319,27 @@ pub enum MethodKind {
     /// Odoo's bulk-create override.
     ApiModelCreateMulti,
     /// Plain instance method, no special semantics.
+    #[default]
     Instance,
 }
 
-impl Default for MethodKind {
-    fn default() -> Self {
-        Self::Instance
-    }
-}
-
 /// Recordset semantics — Odoo methods can bind to a record (single),
 /// a recordset (the default for most methods), or be class-level
 /// (`@api.model`). Captured for cross-language consumers that
 /// project to per-record vs per-collection APIs.
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum RecordSemantics {
     /// Single-record context.
     Record,
     /// Recordset (Odoo default for most methods).
+    #[default]
     Recordset,
     /// Class-level (`@api.model` or no `self`).
     ClassLevel,
 }
 
-impl Default for RecordSemantics {
-    fn default() -> Self {
-        Self::Recordset
-    }
-}
-
 // ─────────────────────────────────────────────────────────────────────
 // Sprint 3 — Action vocabulary with SPO + TeKaMoLo grammar
 // (per docs/ADAPTERS-AND-ACTORS.md + brutal-review cycle 3 fixes)
@@ -368,7 +359,6 @@ impl Default for RecordSemantics {
 #[derive(Debug, Clone, Default, PartialEq, Eq)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
-
 pub struct ActionDef {
     /// Stable identity for the action declaration (e.g.
     /// `ogit-erp/sale.order::action_def::action_confirm`).
@@ -446,23 +436,18 @@ impl EnterEffect {
 /// Disposition when a `KausalSpec::StateGuard` is not satisfied — the Modal
 /// sub-property for the Rubicon statem lowering (OGAR-AST-CONTRACT §6).
 /// `#[non_exhaustive]` per the vocabulary forward-compat convention.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum GuardFailurePolicy {
     /// Transient failure — stay `Pending` and replay after the next
     /// transition. Lowers to `Transition::Postpone`.
     Postponable,
     /// Hard failure — `Pending → Failed` (the default).
+    #[default]
     Reject,
 }
 
-impl Default for GuardFailurePolicy {
-    fn default() -> Self {
-        Self::Reject
-    }
-}
-
 /// A runtime invocation of an `ActionDef` — one per (S, P, O, context)
 /// tuple. Captures the actual subject (which user / cron / cascade
 /// fired this), provenance for tracing, and lifecycle state.
@@ -509,13 +494,14 @@ pub struct ActionInvocation {
 }
 
 /// Subject of a business action — who/what initiated it.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum ActionSubject {
     /// A human user (UI button click, RPC call from authenticated user).
     User,
     /// Internal system trigger (no specific user).
+    #[default]
     System,
     /// Scheduled (`ir.cron`, Rails `Whenever`).
     Cron,
@@ -525,19 +511,14 @@ pub enum ActionSubject {
     Cascade,
 }
 
-impl Default for ActionSubject {
-    fn default() -> Self {
-        Self::System
-    }
-}
-
 /// Temporal context — when does the action happen relative to its
 /// trigger.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum TemporalSpec {
     /// Synchronous, on-call.
+    #[default]
     Immediate,
     /// Queued, async background.
     Deferred,
@@ -548,20 +529,15 @@ pub enum TemporalSpec {
     OnCommit,
 }
 
-impl Default for TemporalSpec {
-    fn default() -> Self {
-        Self::Immediate
-    }
-}
-
 /// Modal context — how is the action performed.
 /// Per B3 YAGNI: dropped `Requires` (no v1 consumer); kept Idempotent
 /// because it gates the dedup mechanism in `ActionInvocation`.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum ModalSpec {
     /// Synchronous, blocking.
+    #[default]
     Sync,
     /// Fire-and-forget.
     Async,
@@ -571,12 +547,6 @@ pub enum ModalSpec {
     Atomic,
 }
 
-impl Default for ModalSpec {
-    fn default() -> Self {
-        Self::Sync
-    }
-}
-
 /// Causal precondition — what triggered this action. **Sum type** per
 /// B1 review fix. Producers populate one variant; the runtime guard
 /// evaluator dispatches on the variant.
@@ -630,11 +600,12 @@ pub struct LokalSpec {
 /// Lifecycle state of an `ActionInvocation`.
 /// Per B2 production-blocker #3: explicit state machine prevents
 /// the silent-gap problem (action started, didn't complete, no record).
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum ActionState {
     /// Emitted but not yet processed by the callcenter.
+    #[default]
     Pending,
     /// Successfully processed; effects committed.
     Committed,
@@ -645,12 +616,6 @@ pub enum ActionState {
     Cancelled,
 }
 
-impl Default for ActionState {
-    fn default() -> Self {
-        Self::Pending
-    }
-}
-
 // ─────────────────────────────────────────────────────────────────────
 // Sprint 3 constructors (per #[non_exhaustive] convention)
 // ─────────────────────────────────────────────────────────────────────
@@ -719,11 +684,12 @@ impl KausalSpec {
 /// Rails `belongs_to`/`has_one`/`has_many`/`has_and_belongs_to_many`,
 /// Odoo `Many2one`/`One2many`/`Many2many` (Odoo collapses `has_one` into
 /// `One2many` constrained to 1).
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[non_exhaustive]
 pub enum AssociationKind {
     /// Owning side of a 1:N — the FK lives on this class's table.
+    #[default]
     BelongsTo,
     /// Non-owning side of a 1:1.
     HasOne,
@@ -801,12 +767,6 @@ pub struct Association {
     pub delegate: Option<bool>,
 }
 
-impl Default for AssociationKind {
-    fn default() -> Self {
-        Self::BelongsTo
-    }
-}
-
 /// An enum-backed column declaration.
 ///
 /// The `source` field captures three Odoo cases (static / computed /
@@ -1543,8 +1503,8 @@ pub mod class_ids {
     /// Promoted Phase-3 from the cross-axis identity gap surfaced in odoo-rs
     /// PR #14: the alignment table seeds `product.template → schema:Product`
     /// + BillingCore (0x61); this id is the OGAR-side identity that closes
-    /// the same axis. `OdooPort` carries `product.template` and
-    /// `product.product` as aliases of `PRODUCT`.
+    ///   the same axis. `OdooPort` carries `product.template` and
+    ///   `product.product` as aliases of `PRODUCT`.
     pub const PRODUCT: u16 = 0x0207;
     /// `accounting_account` (`0x0208`) — general-ledger account (SKR-aligned
     /// chart concept). OSB `Account`, Odoo `account.account` +
@@ -5682,9 +5642,3 @@ mod tests {
         }
     }
 }
-
-impl Default for Language {
-    fn default() -> Self {
-        Self::Ruby
-    }
-}