feat(vocab+class-view): mint PRODUCT (0x0207) + ACCOUNTING_ACCOUNT (0x0208); extend ODOO_ALIASES#111
Merged
AdaWorldAPI merged 1 commit intoJun 23, 2026
Conversation
…x0208); extend ODOO_ALIASES Phase-3 mints from the cross-axis identity gap surfaced in odoo-rs PR #14 (`alignment_pin::seeded_classes_have_compatible_ogar_identity`). `OdooPort` previously covered the commerce arm only (9 aliases); the alignment table declared 15 concepts across 6 basins (BillingCore + SMBAccounting + SmbFoundryCustomer + SmbFoundryInvoice + ProductCatalog + HRFoundation), leaving 11 Odoo classes without a canonical OGAR class_id. This PR closes the highest-impact 4-of-11 gap by minting two product+ accounting concepts and routing their Odoo aliases: PRODUCT (0x0207) ← product.template (master record / catalogue) ← product.product (variant SKU; converges on the same id) ACCOUNTING_ACCOUNT (0x0208) ← account.account (live ledger row) ← account.account.template (SKR03/04 chart-of-accounts template) Same convergence pattern as `account.move ↔ sale.order → COMMERCIAL_DOCUMENT` in the existing commerce arm. Synchronised across the codebook: - CODEBOOK rows + class_ids constants + class_ids::ALL entries - all_promoted_classes() (ogar-vocab) with new product() / accounting_account() builders (Class definitions with minimal schema:Product / fibo:Account-aligned attributes) - all_canonical_classes() (ogar-class-view) — the ObjectView registry - ODOO_ALIASES (ports.rs) — 4 new entries (9 → 13) - Tests updated for new count (Commerce concepts.count(): 6 → 8) + commerce_concept loop iterates the 2 new names - Odoo alias count drift assert: 9 → 13 - Stale "32 promoted" doc comments in ogar-class-view refreshed to count- agnostic phrasing Deferred for follow-up (7 remaining missing aliases per odoo-rs #14): - product.pricelist, product.pricelist.item, uom.uom → ProductCatalog basin candidates (PRICELIST / PRICELIST_RULE / UNIT_OF_MEASURE — additional 0x02XX mints; needs a "schema:PriceSpecification" alignment review first) - hr.employee, hr.department, hr.job, hr.contract → HRFoundation basin candidates (new 0x0CXX concept domain proposal; needs separate keystone- style §7 spec review like AuthStore #110 did) Tests: - ogar-vocab: 93 passed (was 91 pre-mint; +2 doctests pass) - ogar-class-view: 11 passed - clippy clean on my new code; fmt clean Refs: - AdaWorldAPI/odoo-rs#14 (alignment-pin surfaces the 11-class gap) - AdaWorldAPI/odoo-rs#15 (Phase-2 hydrator pull) - AdaWorldAPI/odoo-rs#16 (repatriation-frame canonical citations) - AdaWorldAPI/lance-graph#594 (B of A+B+C: hydrator silent suffix bugs) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase-3 mint (C of A+B+C) — close the cross-axis identity gap
Phase-3 mints from the cross-axis identity gap surfaced in
odoo-rs PR #14's
alignment_pin::seeded_classes_have_compatible_ogar_identity.OdooPortpreviously covered the commerce arm only (9 aliases); the alignment table
declared 15 concepts across 6 basins (BillingCore + SMBAccounting +
SmbFoundryCustomer + SmbFoundryInvoice + ProductCatalog + HRFoundation),
leaving 11 Odoo classes without a canonical OGAR class_id.
This PR closes the highest-impact 4-of-11 gap by minting two
product+accounting concepts and routing their Odoo aliases.
What lands
Same convergence pattern as
account.move ↔ sale.order → COMMERCIAL_DOCUMENTin the existing commerce arm.
Synchronised across the codebook
ogar-vocab/src/lib.rsCODEBOOKproduct,accounting_account)ogar-vocab/src/lib.rsclass_idsmodogar-vocab/src/lib.rsclass_ids::ALLogar-vocab/src/lib.rsbuildersproduct()andaccounting_account()Class fns with minimal schema:Product / fibo:Account-aligned attributesogar-vocab/src/lib.rsall_promoted_classes()ogar-vocab/src/lib.rstestsconcepts_in_domain(Commerce).count(): 6 → 8ogar-vocab/src/ports.rsODOO_ALIASESogar-class-view/src/lib.rsall_canonical_classes()ogar-class-view/src/lib.rsdoc commentsClass attribute shapes
Minimal
schema:Product/fibo:Account-aligned attributes:Same density as
commercial_document(),tax_policy(),currency_policy()—small typed-attribute set that downstream renderers extend per app.
Deferred for follow-up (7 of 11 missing aliases)
product.pricelistPRICELIST(0x0209?)schema:PriceSpecificationproduct.pricelist.itemPRICELIST_RULE(0x020A?)schema:UnitPriceSpecificationuom.uomUNIT_OF_MEASURE(0x020B?)qudt:Unithr.employeeEMPLOYEE(0x0C01?)vcard:Individual— needs new HR concept domain 0x0Chr.departmentORGANIZATIONAL_UNIT(0x0C02?)org:OrganizationalUnithr.jobJOB_ROLE(0x0C03?)org:Rolehr.contractEMPLOYMENT_CONTRACT(0x0C04?)fibo:ContractThe 0x02XX product-catalog additions need a
schema:PriceSpecificationalignment review first. The HR cluster needs a new 0x0CXX concept domain
proposal, paralleling AuthStore #110's keystone §7 review pattern. Queued
as a follow-up PR once the schema decisions are made.
Tests
ogar-vocab: 93 passed (was 91 pre-mint; +2 from new constants going through the loop)ogar-class-view: 11 passedCross-repo refs
odoo-rs#14— alignment-pin surfaces the 11-class gapodoo-rs#15— Phase-2 hydrator pullodoo-rs#16— repatriation-frame canonical citations including this PR's parent OGAR canon (docs(framing): OGAR as IR — the compiler framing as a one-pager #104/vocab/exports/ skeleton + Odoo-digest framing corrections #107/epiphany: OGIT was already a semantic compiler's symbol table #109/Mint the 0x0B AuthStore class family (keystone §7, confirmed by OGIT shape) #110)lance-graph#594— B of A+B+C: hydrator silent suffix bugs