Skip to content

feat(ogar-vocab): add OpenProject Member alias for project_membership#113

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/openproject-alias-member
Jun 23, 2026
Merged

feat(ogar-vocab): add OpenProject Member alias for project_membership#113
AdaWorldAPI merged 1 commit into
mainfrom
claude/openproject-alias-member

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

Adds Member as an OpenProject alias for PROJECT_MEMBERSHIP (0x0108), keeping Membership as a deprecated synonym. Both names resolve to the same canonical id — purely additive.

("Member",     PROJECT_MEMBERSHIP),  // canonical (matches OP corpus + Redmine)
("Membership", PROJECT_MEMBERSHIP),  // deprecated synonym, kept for backcompat

Why

The earlier OpenProject alias was Membership — pre-snapshot prose. The engine-walking corpus snapshot in openproject-nexgen-rs op-canon (extracted from the real OpenProject Rails source via ruff_ruby_spo::extract_app_with) carries Member — the same name Redmine ships (both forks ship the membership join row as Member). The OGAR alias was therefore guessing the surface name; the actual canonical surface is Member.

Closes a self-pinned drift

openproject-nexgen-rs#56 added a deliberately-flipping test, port_and_snapshot_membership_vocab_mismatch_is_known, that asserts:

// KNOWN GAP: the port aliases this concept as `Membership`, not `Member`.
assert_eq!(class_id_of("Member"), None,
    "if this is now Some(_), OGAR aligned the alias to the corpus name —      update the OPENPROJECT_ALIASES follow-up and remove this pin");

Once op-canon bumps its ogar-vocab git pin after this lands, the pin self-fails by design — reminding the next session to drop it in a tiny op-canon follow-up.

Scope

  • OPENPROJECT_ALIASES: +1 row (Member); Membership retained.
  • OP↔RM convergence pair in tests: ("Membership", "Member", PROJECT_MEMBERSHIP)("Member", "Member", PROJECT_MEMBERSHIP) (canonical pair; convergence passes either way).
  • each_port_has_expected_alias_count: OpenProject count 27 → 28; comment updated to name the deprecated synonym row.
  • New focused test: openproject_member_and_membership_both_resolve_to_project_membership — pins the additive contract (both names → same id; OP Member ↔ RM Member converge).

Build

  • Toolchain 1.95. cargo test -p ogar-vocab --lib ports::28 passed (+1 new). cargo check --workspace --all-targets clean.
  • No public API change.

Cross-refs

The earlier OpenProject alias for project_membership (0x0108) was the
pre-snapshot prose name `Membership`. The engine-walking corpus snapshot in
openproject-nexgen-rs op-canon (extracted from the real OpenProject Rails
source) carries `Member` — same as Redmine (both forks ship the join row
as `Member`). The OGAR alias was therefore guessing the surface name; the
actual canonical surface is `Member`.

This is purely additive: BOTH names now resolve to PROJECT_MEMBERSHIP.

  ("Member", PROJECT_MEMBERSHIP)      <- canonical (matches OP corpus + Redmine)
  ("Membership", PROJECT_MEMBERSHIP)  <- deprecated synonym, kept for any
                                         downstream consumer holding the old
                                         name; never breaks resolution

Closes the openproject-nexgen-rs#56 pinned drift-guard test
`port_and_snapshot_membership_vocab_mismatch_is_known` — once op-canon bumps
its ogar-vocab git pin after this lands, `OpenProjectPort::class_id("Member")`
flips from `None` to `Some(PROJECT_MEMBERSHIP)`, the pin self-fails by design,
and op-canon drops it in a small follow-up.

Also updates the OP↔RM convergence pair to use Member ↔ Member (the canonical
spelling) and adds a focused test pinning the additive contract.

OpenProject alias count: 27 → 28 (the new Member row).

cargo +1.95 test -p ogar-vocab --lib ports:: -> 28 passed (+1); workspace
check --all-targets clean.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@AdaWorldAPI AdaWorldAPI merged commit fea4dfd into main Jun 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants