feat(ogar-vocab): add OpenProject Member alias for project_membership#113
Merged
Conversation
The earlier OpenProject alias for project_membership (0x0108) was the
pre-snapshot prose name `Membership`. The engine-walking corpus snapshot in
openproject-nexgen-rs op-canon (extracted from the real OpenProject Rails
source) carries `Member` — same as Redmine (both forks ship the join row
as `Member`). The OGAR alias was therefore guessing the surface name; the
actual canonical surface is `Member`.
This is purely additive: BOTH names now resolve to PROJECT_MEMBERSHIP.
("Member", PROJECT_MEMBERSHIP) <- canonical (matches OP corpus + Redmine)
("Membership", PROJECT_MEMBERSHIP) <- deprecated synonym, kept for any
downstream consumer holding the old
name; never breaks resolution
Closes the openproject-nexgen-rs#56 pinned drift-guard test
`port_and_snapshot_membership_vocab_mismatch_is_known` — once op-canon bumps
its ogar-vocab git pin after this lands, `OpenProjectPort::class_id("Member")`
flips from `None` to `Some(PROJECT_MEMBERSHIP)`, the pin self-fails by design,
and op-canon drops it in a small follow-up.
Also updates the OP↔RM convergence pair to use Member ↔ Member (the canonical
spelling) and adds a focused test pinning the additive contract.
OpenProject alias count: 27 → 28 (the new Member row).
cargo +1.95 test -p ogar-vocab --lib ports:: -> 28 passed (+1); workspace
check --all-targets clean.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
Memberas an OpenProject alias forPROJECT_MEMBERSHIP(0x0108), keepingMembershipas a deprecated synonym. Both names resolve to the same canonical id — purely additive.Why
The earlier OpenProject alias was
Membership— pre-snapshot prose. The engine-walking corpus snapshot inopenproject-nexgen-rsop-canon(extracted from the real OpenProject Rails source viaruff_ruby_spo::extract_app_with) carriesMember— the same name Redmine ships (both forks ship the membership join row asMember). The OGAR alias was therefore guessing the surface name; the actual canonical surface isMember.Closes a self-pinned drift
openproject-nexgen-rs#56 added a deliberately-flipping test,
port_and_snapshot_membership_vocab_mismatch_is_known, that asserts:Once op-canon bumps its
ogar-vocabgit pin after this lands, the pin self-fails by design — reminding the next session to drop it in a tiny op-canon follow-up.Scope
OPENPROJECT_ALIASES: +1 row (Member);Membershipretained.("Membership", "Member", PROJECT_MEMBERSHIP)→("Member", "Member", PROJECT_MEMBERSHIP)(canonical pair; convergence passes either way).each_port_has_expected_alias_count: OpenProject count 27 → 28; comment updated to name the deprecated synonym row.openproject_member_and_membership_both_resolve_to_project_membership— pins the additive contract (both names → same id; OPMember↔ RMMemberconverge).Build
1.95.cargo test -p ogar-vocab --lib ports::→ 28 passed (+1 new).cargo check --workspace --all-targetsclean.Cross-refs