action handler: B2-lift applicabilities + B2-transport scorecard reflection#123
Merged
Merged
Conversation
…es read Completes B2-lift (the REST registration instance lift). The capabilities half shipped in #122; this adds the applicabilities half the same way. - ogar-from-schema/src/registration.rs (producer, parser-free): RegisteredApplicability DTO + RegisteredApplicabilities (MapOfApplicabilities, keyed by handler id) + lift_applicabilities -> BTreeMap<handler, Vec<KausalSpec>>. The inner filter-list field name isn't pinned by the harvested spec, so the DTO accepts modelFilters / model / filters via serde aliases (defaults empty) — a real response binds without a code change once the name is confirmed. The element mapping (ModelFilter{Var,Mode,Value} -> StateGuard) is the documented, exact part. - ogar-action-handler::parse_applicabilities — the serde_json read of a GET /applicabilities body (runtime owns I/O). Proven by rest_applicabilities_lift_to_per_handler_guards (real JSON -> per-handler StateGuard sets, alias accepted). The lifted guards are the same StateGuards the hard gate's commit_via evaluates before executing — so the instance lift now feeds both halves of an ActionDef: capabilities -> ActionParam[] signature, applicabilities -> StateGuard. Docs: ARAGO-ACTIONHANDLER-PARITY (applicabilities row → SHIPPED, §3 bullet, verdict, cross-refs); D-ACTIONHANDLER-B2LIFT regraded G with a cited canon-pass correction (append-only — original body kept, "Remaining" note superseded). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EYvNjD8M8LMNYbRy3gq2FP
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
AdaWorldAPI
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes B2-lift (the REST registration instance lift) and records the B2-transport daemon (shipped in rs-graph-llm #18) in the parity scorecard.
B2-lift applicabilities —
ogar-from-schema/registration.rs+ogar-action-handlerThe capabilities half shipped in #122; this adds the applicabilities half the same way, so OGAR reads its whole deployed registration from REST.
RegisteredApplicability+RegisteredApplicabilities(MapOfApplicabilities, keyed by handler id) +lift_applicabilities→BTreeMap<handler, Vec<KausalSpec>>. Inner filter-list field name acceptsmodelFilters/model/filtersvia serde aliases (the spec didn't pin it); the element mappingModelFilter{Var,Mode,Value}→StateGuardis exact.parse_applicabilities— theserde_jsonread of aGET /applicabilitiesbody.rest_applicabilities_lift_to_per_handler_guardsproves it.The lifted guards are the same
StateGuards the hard gate'scommit_viaevaluates — so the instance lift now feeds both halves of anActionDef: capabilities →ActionParam[], applicabilities →StateGuard.B2-transport scorecard reflection (code in rs-graph-llm #18)
Docs-only update recording the live daemon:
graph-flow-action-ogar::daemonis a transport-agnostic core (Daemon::react/serve) + aTransporttrait + theaction-wsWsTransportedge, with the connection identity shaped after OGITNTO/Auth/Configuration. HIRO is multi-wire (WebSocket + Kafka), so the dispatch is written once and the wire is a thin edge — Kafka reserved. Captured asD-ACTIONHANDLER-TRANSPORT+E-ACTIONHANDLER-TRANSPORT.Parity state
B2-lift fully shipped; B2-transport WebSocket edge shipped. Remaining for a live drop-in: the Kafka transport edge (HIRO's internal bus — needs the topic/record shape) and the non-native executor targets (SSH/REST).
Tests
58 green (49
ogar-from-schema+ 7ogar-action-handler+ 2 integration), clippy-clean.D-ACTIONHANDLER-B2LIFTregradedGwith a cited append-only canon-pass correction.Sources:
github.com/arago/ActionHandlers,arago/python-hiro-stonebranch-actionhandler, and the HIRO 7 Action API spec.🤖 Generated with Claude Code