Clippy cleanup: reduce warnings from 191 to 24 across workspace

- Migrate deprecated bundle_byte_slices → try_bundle_byte_slices (rustynum_accel, bind_space)
- Migrate deprecated rng.gen() → rng.random() (spo.rs)
- Replace Default::default() mutation patterns with struct literals (lance.rs, lance_persistence.rs)
- Fix .clone() on Copy type [u64; 256] (proof_tactics.rs)
- Fix filter_map → map where Some always returned (flight/server.rs)
- Fix .clone() on double reference → dereference (cypher_bridge.rs)
- Fix is_multiple_of clippy lint (wide_container.rs)
- Fix loop-indexing → iter_mut().enumerate() (wide_meta.rs)
- Fix manual slice copy → copy_from_slice (wide_meta.rs)
- Remove unused imports and variables across spo/, orchestration/, flight/
- Fix redundant field names in struct init (causal_trajectory.rs)

Remaining 24 warnings: 21 crewai-rust dead code, 2 n8n-core, 1 spo::spo module naming.

https://claude.ai/code/session_0152b2NJYnjCJjvMAmgsTx3p

Author: claude

crates/ladybug-contract/src/wide_container.rs

@@ -190,7 +190,7 @@ impl WideContainer {
             return items[0].clone();
         }
         let threshold = items.len() / 2;
-        let even = items.len() % 2 == 0;
+        let even = items.len().is_multiple_of(2);
         let mut result = WideContainer::zero();
         for word in 0..WIDE_WORDS {
             let mut out = 0u64;

crates/ladybug-contract/src/wide_meta.rs

@@ -355,8 +355,8 @@ impl<'a> WideMetaView<'a> {
     /// Read all 10 layer activations.
     pub fn layer_activations(&self) -> [f64; 10] {
         let mut out = [0.0f64; 10];
-        for i in 0..10 {
-            out[i] = f64::from_bits(self.words[W_LAYER10_BASE + i]);
+        for (i, slot) in out.iter_mut().enumerate() {
+            *slot = f64::from_bits(self.words[W_LAYER10_BASE + i]);
         }
         out
     }
@@ -632,9 +632,7 @@ impl<'a> WideMetaViewMut<'a> {
             self.words[W_SPINE_BASE + i] = 0;
         }
         let n = ancestors.len().min(MAX_SPINE_DEPTH);
-        for i in 0..n {
-            self.words[W_SPINE_BASE + i] = ancestors[i];
-        }
+        self.words[W_SPINE_BASE..W_SPINE_BASE + n].copy_from_slice(&ancestors[..n]);
     }
 
     // ====================================================================

src/core/rustynum_accel.rs

@@ -141,7 +141,8 @@ pub fn container_bundle(items: &[&Container]) -> Container {
         .map(|c| view_u64_as_bytes(&c.words))
         .collect();
 
-    let result_bytes = rustynum_rs::NumArrayU8::bundle_byte_slices(&slices);
+    let result_bytes = rustynum_rs::NumArrayU8::try_bundle_byte_slices(&slices)
+        .expect("bundle_byte_slices: all slices same length");
 
     // Convert back to Container
     let mut container = Container::zero();

src/cypher_bridge.rs

@@ -470,7 +470,7 @@ fn properties_to_fingerprint(
     let mut content = label.to_string();
     // Sort properties for determinism
     let mut sorted: Vec<_> = properties.iter().collect();
-    sorted.sort_by_key(|(k, _)| k.clone());
+    sorted.sort_by_key(|(k, _)| *k);
     for (k, v) in sorted {
         content.push(':');
         content.push_str(k);
@@ -618,12 +618,10 @@ fn parse_where_clause(s: &str) -> Result<WhereClause, String> {
 /// Extract label from a MATCH/MERGE/CREATE pattern like "(n:System {...})"
 fn extract_label(cypher: &str) -> Option<String> {
     // Find first (variable:Label pattern
-    let mut in_parens = false;
     let chars: Vec<char> = cypher.chars().collect();
     let mut i = 0;
     while i < chars.len() {
         if chars[i] == '(' {
-            in_parens = true;
             i += 1;
             // Skip whitespace
             while i < chars.len() && chars[i].is_whitespace() { i += 1; }
@@ -661,7 +659,7 @@ fn parse_node_pattern(cypher: &str) -> Result<(Vec<String>, HashMap<String, Cyph
     let label_part = &inner[..brace_start];
 
     for part in label_part.split(':').skip(1) {
-        let label = part.trim().split_whitespace().next().unwrap_or("").to_string();
+        let label = part.split_whitespace().next().unwrap_or("").to_string();
         if !label.is_empty() {
             labels.push(label);
         }

src/flight/crew_actions.rs

@@ -489,7 +489,7 @@ pub fn execute_crew_action(
         "persona.attach_yaml" => {
             let yaml = std::str::from_utf8(body).map_err(|e| format!("Invalid UTF-8: {}", e))?;
 
-            let persona = crate::orchestration::persona::Persona::from_yaml(yaml)?;
+            let _persona = crate::orchestration::persona::Persona::from_yaml(yaml)?;
             // Extract agent_slot from first line comment or separate field
             // For now, require JSON wrapper with agent_slot
             #[derive(serde::Deserialize)]

src/flight/server.rs

@@ -1257,7 +1257,7 @@ fn build_search_result_data(
 ) -> Vec<(u16, [u64; FINGERPRINT_WORDS], Option<String>, u32, f32, u8)> {
     results
         .iter()
-        .filter_map(|(idx, dist)| {
+        .map(|(idx, dist)| {
             // Get fingerprint from HDR index
             // Note: We don't have direct address mapping, so we use index as pseudo-address
             // In a real implementation, HDR index would store (addr, fingerprint) pairs
@@ -1272,14 +1272,14 @@ fn build_search_result_data(
             };
 
             // Return placeholder fingerprint - real impl would look up from index
-            Some((
+            (
                 addr,
                 [0u64; FINGERPRINT_WORDS],
                 None,
                 *dist,
                 similarity,
                 cascade_level,
-            ))
+            )
         })
         .collect()
 }

src/orchestration/crew_bridge.rs

@@ -34,16 +34,16 @@
 
 use super::a2a::{A2AMessage, A2AProtocol, DeliveryStatus};
 use super::agent_card::{AgentCard, AgentRegistry};
-use super::blackboard_agent::{AgentBlackboard, BlackboardRegistry};
+use super::blackboard_agent::BlackboardRegistry;
 use super::handover::{HandoverDecision, HandoverPolicy};
 use super::kernel_extensions::{
     FilterPipeline, KernelGuardrail, MemoryBank, ObservabilityManager, VerificationEngine,
 };
 use super::meta_orchestrator::MetaOrchestrator;
-use super::persona::{Persona, PersonaRegistry};
+use super::persona::PersonaRegistry;
 use super::semantic_kernel::SemanticKernel;
 use super::thinking_template::{ThinkingTemplate, ThinkingTemplateRegistry};
-use crate::storage::bind_space::{Addr, BindSpace, FINGERPRINT_WORDS};
+use crate::storage::bind_space::{Addr, BindSpace};
 use serde::{Deserialize, Serialize};
 
 /// Task status in the dispatch pipeline

src/orchestration/handover.rs

@@ -23,7 +23,7 @@
 //! 4. **Dunning-Kruger guard** — agents with low coherence but high
 //!    confidence are flagged for metacognitive review
 
-use crate::cognitive::{GateState, ThinkingStyle};
+use crate::cognitive::GateState;
 use serde::{Deserialize, Serialize};
 
 // =============================================================================

src/orchestration/kernel_extensions.rs

@@ -50,7 +50,7 @@
 //! └───────────────────────────────────────────────────────────────────────┘
 //! ```
 
-use super::semantic_kernel::{CausalRung, KernelTruth, KernelZone};
+use super::semantic_kernel::{KernelTruth, KernelZone};
 use crate::storage::bind_space::{Addr, BindSpace, FINGERPRINT_WORDS};
 use serde::{Deserialize, Serialize};
 

src/spo/causal_trajectory.rs

@@ -34,16 +34,16 @@
 //! DN mutation guidance, and warm-start capability.
 
 use rustynum_bnn::causal_trajectory::{
-    CausalArrow, CausalChain, CausalDirection, CausalLink, CausalRelation, CausalSaliency,
-    CausalTrajectory, DominantPlane, EwmCorrection, EwmTier, HaloTransition,
-    NarsCausalStatement, NarsTruth, ResonatorSnapshot, RifDiff, SigmaEdge, SigmaNode,
+    CausalArrow, CausalChain, CausalDirection, CausalRelation, CausalSaliency,
+    CausalTrajectory, DominantPlane,
+    NarsCausalStatement, NarsTruth, ResonatorSnapshot, SigmaEdge,
 };
-use rustynum_bnn::{GrowthPath, HaloType, InferenceMode, MutationOp};
-use rustynum_core::{CollapseGate, SigmaGate, SignificanceLevel};
+use rustynum_bnn::{GrowthPath, InferenceMode, MutationOp};
+use rustynum_core::{CollapseGate, SigmaGate};
 
 use crate::nars::TruthValue;
 use super::gestalt::GestaltState;
-use super::spo_harvest::{Plane, SpoDistanceResult, TypedHalo};
+use super::spo_harvest::{Plane, SpoDistanceResult};
 use super::shift_detector::SpoShiftDetector;
 
 // =============================================================================
@@ -201,7 +201,7 @@ impl TrajectoryHydrator {
                 edge: edge.clone(),
                 truth: nars_to_truth(&edge.truth),
                 growth_path: Some(growth_path),
-                gestalt: gestalt.clone(),
+                gestalt,
             })
             .collect();