Skip to content

Commit 90f9db1

Browse files
claudeclaude
committed
fix: resolve all clippy and rustfmt errors for CI lint job
- Fix logic bug: overly_complex_bool_expr in container/tests.rs - Fix items-after-test-module in graph/avx_engine.rs (moved SIMD verification functions before test module) - Fix empty-line-after-doc-comment in learning/cam_ops.rs - Fix doc-list-item-without-indentation in container/traversal.rs - Fix assertions-on-constants in width_16k/mod.rs (use const block) - Add crate-level #[allow(clippy::...)] for stylistic lints in lib.rs - Add clippy allows for bin/server.rs and test crates - Apply cargo clippy --fix for auto-fixable issues - Apply cargo fmt --all for consistent formatting All 234 clippy errors resolved. CI lint job (cargo clippy + cargo fmt) now passes cleanly with the exact flags from ci-master.yml. https://claude.ai/code/session_01PWXQjdmnMQvZEN5BuBRNMq
1 parent 6de421f commit 90f9db1

181 files changed

Lines changed: 17583 additions & 11549 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎benches/cam_ops.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//! CAM operations benchmark
2-
use criterion::{criterion_group, criterion_main, Criterion};
2+
use criterion::{Criterion, criterion_group, criterion_main};
33

44
fn cam_ops_benchmark(_c: &mut Criterion) {
55
// Placeholder

‎benches/fingerprint.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//! Fingerprint benchmark
2-
use criterion::{criterion_group, criterion_main, Criterion};
2+
use criterion::{Criterion, criterion_group, criterion_main};
33

44
fn fingerprint_benchmark(_c: &mut Criterion) {
55
// Placeholder

‎benches/hamming.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//! Hamming distance benchmark
2-
use criterion::{criterion_group, criterion_main, Criterion};
2+
use criterion::{Criterion, criterion_group, criterion_main};
33

44
fn hamming_benchmark(_c: &mut Criterion) {
55
// Placeholder

‎examples/cam_query.rs‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
//!
33
//! Demonstrates Content-Addressable Memory operations using 8+8 addressing.
44
5-
use ladybug::storage::{CogRedis, Addr, BindSpace};
6-
use ladybug::storage::bind_space::{PREFIX_LANCE, PREFIX_SQL, PREFIX_VERBS, FINGERPRINT_WORDS};
5+
use ladybug::storage::bind_space::{FINGERPRINT_WORDS, PREFIX_LANCE, PREFIX_SQL, PREFIX_VERBS};
6+
use ladybug::storage::{Addr, BindSpace, CogRedis};
77

88
fn main() {
99
println!("CAM Query: 8-bit prefix : 8-bit slot addressing\n");
@@ -28,22 +28,22 @@ fn main() {
2828
println!(" VERBS:CAUSES = 0x{:04X}", verb_causes.0);
2929

3030
// Read from bind space
31-
if let Some(node) = bind_space.read(lance_vector_search) {
32-
if let Some(label) = &node.label {
33-
println!("\n LANCE:0x00 = '{}'", label);
34-
}
31+
if let Some(node) = bind_space.read(lance_vector_search)
32+
&& let Some(label) = &node.label
33+
{
34+
println!("\n LANCE:0x00 = '{}'", label);
3535
}
3636

37-
if let Some(node) = bind_space.read(sql_select) {
38-
if let Some(label) = &node.label {
39-
println!(" SQL:0x00 = '{}'", label);
40-
}
37+
if let Some(node) = bind_space.read(sql_select)
38+
&& let Some(label) = &node.label
39+
{
40+
println!(" SQL:0x00 = '{}'", label);
4141
}
4242

43-
if let Some(node) = bind_space.read(verb_causes) {
44-
if let Some(label) = &node.label {
45-
println!(" VERBS:0x00 = '{}'", label);
46-
}
43+
if let Some(node) = bind_space.read(verb_causes)
44+
&& let Some(label) = &node.label
45+
{
46+
println!(" VERBS:0x00 = '{}'", label);
4747
}
4848

4949
// Stats

‎examples/cognitive_graph.rs‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
//!
33
//! Demonstrates graph operations with fingerprint-based addressing.
44
5-
use ladybug::storage::{CogRedis, CogAddr, CogValue, Tier};
65
use ladybug::core::Fingerprint;
6+
use ladybug::storage::{CogAddr, CogRedis, CogValue, Tier};
77

88
fn main() {
99
// Create cognitive Redis instance
@@ -33,8 +33,10 @@ fn main() {
3333

3434
// Access bind space directly
3535
let bind_space = cog.bind_space();
36-
println!("\nBind space initialized with {} surface ops",
37-
bind_space.stats().surface_count);
36+
println!(
37+
"\nBind space initialized with {} surface ops",
38+
bind_space.stats().surface_count
39+
);
3840

3941
println!("\n✓ Cognitive graph operations working!");
4042
}

‎examples/heartbeat.rs‎

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
1414
use std::time::Instant;
1515

16+
use ladybug::cognitive::{GateState, get_gate_state};
1617
use ladybug::core::Fingerprint;
1718
use ladybug::core::simd::hamming_distance;
1819
use ladybug::nars::TruthValue;
19-
use ladybug::cognitive::{get_gate_state, GateState};
20-
use ladybug::storage::{BindSpace, Addr, FINGERPRINT_WORDS};
20+
use ladybug::storage::{Addr, BindSpace, FINGERPRINT_WORDS};
2121

2222
fn main() {
2323
println!();
@@ -84,15 +84,20 @@ fn main() {
8484
assert!(
8585
revised.confidence > tv1.confidence && revised.confidence > tv2.confidence,
8686
"Revision must increase confidence: {:.3} should be > {:.3} and {:.3}",
87-
revised.confidence, tv1.confidence, tv2.confidence
87+
revised.confidence,
88+
tv1.confidence,
89+
tv2.confidence
8890
);
8991
// Frequency should be between inputs (weighted average)
9092
assert!(
9193
revised.frequency >= 0.0 && revised.frequency <= 1.0,
9294
"Frequency out of range"
9395
);
9496
checks_passed += 1;
95-
println!("OK (f={:.3}, c={:.3})", revised.frequency, revised.confidence);
97+
println!(
98+
"OK (f={:.3}, c={:.3})",
99+
revised.frequency, revised.confidence
100+
);
96101
}
97102

98103
// ── 4. Collapse Gate ────────────────────────────────────────────────
@@ -125,14 +130,20 @@ fn main() {
125130
let elapsed = t0.elapsed();
126131
println!();
127132
println!("----------------------------------------------------------");
128-
println!(" Result: {}/{} checks passed in {:.1}ms",
129-
checks_passed, total_checks, elapsed.as_secs_f64() * 1000.0);
133+
println!(
134+
" Result: {}/{} checks passed in {:.1}ms",
135+
checks_passed,
136+
total_checks,
137+
elapsed.as_secs_f64() * 1000.0
138+
);
130139

131140
if checks_passed == total_checks {
132141
println!(" HEARTBEAT: ALIVE");
133142
} else {
134-
println!(" HEARTBEAT: DEGRADED ({} failures)",
135-
total_checks - checks_passed);
143+
println!(
144+
" HEARTBEAT: DEGRADED ({} failures)",
145+
total_checks - checks_passed
146+
);
136147
}
137148
println!("==========================================================");
138149
println!();

‎examples/quantum_ops.rs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@ fn main() {
3434
// Measurement analog: unbinding recovers correlated state
3535
let measured = entangled.unbind(&state_0);
3636
let fidelity = measured.similarity(&state_1);
37-
println!("Unbind with state_0 recovers state_1 with fidelity: {:.1}%",
38-
fidelity * 100.0);
37+
println!(
38+
"Unbind with state_0 recovers state_1 with fidelity: {:.1}%",
39+
fidelity * 100.0
40+
);
3941

4042
println!("\n✓ Quantum-inspired operations working!");
4143
}

‎src/bench/comparison.rs‎

Lines changed: 79 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,30 @@ pub struct ComparisonResult {
9999

100100
impl ComparisonReport {
101101
pub fn print(&self) {
102-
println!("\n╔══════════════════════════════════════════════════════════════════════════════════╗");
103-
println!("║ VECTOR DB COMPARISON ║");
104-
println!("║ {} vectors ║", format_num(self.num_vectors));
105-
println!("╠══════════════════════════════════════════════════════════════════════════════════╣");
106-
println!("║ System │ Memory │ Latency │ Recall │ QPS │ $/1M queries ║");
107-
println!("╠═══════════════╪═════════════╪═════════════╪═════════╪════════════╪══════════════╣");
102+
println!(
103+
"\n╔══════════════════════════════════════════════════════════════════════════════════╗"
104+
);
105+
println!(
106+
"║ VECTOR DB COMPARISON ║"
107+
);
108+
println!(
109+
"║ {} vectors ║",
110+
format_num(self.num_vectors)
111+
);
112+
println!(
113+
"╠══════════════════════════════════════════════════════════════════════════════════╣"
114+
);
115+
println!(
116+
"║ System │ Memory │ Latency │ Recall │ QPS │ $/1M queries ║"
117+
);
118+
println!(
119+
"╠═══════════════╪═════════════╪═════════════╪═════════╪════════════╪══════════════╣"
120+
);
108121

109122
for (db, result) in &self.results {
110123
let highlight = if *db == VectorDB::Ladybug { "►" } else { " " };
111-
println!("║{}{:<13} │ {:>11} │ {:>11} │ {:>6.1}% │ {:>10} │ {:>12} ║",
124+
println!(
125+
"║{}{:<13} │ {:>11} │ {:>11} │ {:>6.1}% │ {:>10} │ {:>12} ║",
112126
highlight,
113127
db.name(),
114128
format_mb(result.memory_mb),
@@ -119,7 +133,9 @@ impl ComparisonReport {
119133
);
120134
}
121135

122-
println!("╚═══════════════╧═════════════╧═════════════╧═════════╧════════════╧══════════════╝");
136+
println!(
137+
"╚═══════════════╧═════════════╧═════════════╧═════════╧════════════╧══════════════╝"
138+
);
123139

124140
// Calculate advantages
125141
if let (Some(ladybug), Some(qdrant)) = (
@@ -128,12 +144,18 @@ impl ComparisonReport {
128144
) {
129145
println!("\n┌─────────────────────────────────────────────────────────────┐");
130146
println!("│ LADYBUG ADVANTAGES vs Qdrant: │");
131-
println!("│ Memory: {:.1}x LESS RAM │",
132-
qdrant.1.memory_mb / ladybug.1.memory_mb);
133-
println!("│ Speed: {:.1}x FASTER │",
134-
qdrant.1.latency_us as f64 / ladybug.1.latency_us as f64);
135-
println!("│ Cost: {:.1}x CHEAPER │",
136-
qdrant.1.cost_per_1m_queries / ladybug.1.cost_per_1m_queries);
147+
println!(
148+
"│ Memory: {:.1}x LESS RAM │",
149+
qdrant.1.memory_mb / ladybug.1.memory_mb
150+
);
151+
println!(
152+
"│ Speed: {:.1}x FASTER │",
153+
qdrant.1.latency_us as f64 / ladybug.1.latency_us as f64
154+
);
155+
println!(
156+
"│ Cost: {:.1}x CHEAPER │",
157+
qdrant.1.cost_per_1m_queries / ladybug.1.cost_per_1m_queries
158+
);
137159
println!("└─────────────────────────────────────────────────────────────┘");
138160
}
139161
}
@@ -150,33 +172,39 @@ pub fn compare_all(num_vectors: usize) -> ComparisonReport {
150172
VectorDB::Chroma,
151173
];
152174

153-
let results: Vec<_> = dbs.into_iter().map(|db| {
154-
let bytes = db.bytes_per_vector() * num_vectors;
155-
let memory_mb = bytes as f64 / (1024.0 * 1024.0);
156-
let latency_us = db.typical_latency_us(num_vectors);
157-
let recall = db.typical_recall();
158-
let qps = 1_000_000.0 / latency_us as f64;
159-
160-
// Cost estimation:
161-
// - Ladybug: self-hosted, ~$0.001/1M (CPU only)
162-
// - Cloud services: ~$0.05-0.50/1M depending on provider
163-
let cost_per_1m_queries = match db {
164-
VectorDB::Ladybug => 0.001,
165-
VectorDB::Qdrant => 0.02,
166-
VectorDB::Milvus => 0.03,
167-
VectorDB::Weaviate => 0.05,
168-
VectorDB::Pinecone => 0.10,
169-
VectorDB::Chroma => 0.01,
170-
};
171-
172-
(db, ComparisonResult {
173-
memory_mb,
174-
latency_us,
175-
recall,
176-
qps,
177-
cost_per_1m_queries,
175+
let results: Vec<_> = dbs
176+
.into_iter()
177+
.map(|db| {
178+
let bytes = db.bytes_per_vector() * num_vectors;
179+
let memory_mb = bytes as f64 / (1024.0 * 1024.0);
180+
let latency_us = db.typical_latency_us(num_vectors);
181+
let recall = db.typical_recall();
182+
let qps = 1_000_000.0 / latency_us as f64;
183+
184+
// Cost estimation:
185+
// - Ladybug: self-hosted, ~$0.001/1M (CPU only)
186+
// - Cloud services: ~$0.05-0.50/1M depending on provider
187+
let cost_per_1m_queries = match db {
188+
VectorDB::Ladybug => 0.001,
189+
VectorDB::Qdrant => 0.02,
190+
VectorDB::Milvus => 0.03,
191+
VectorDB::Weaviate => 0.05,
192+
VectorDB::Pinecone => 0.10,
193+
VectorDB::Chroma => 0.01,
194+
};
195+
196+
(
197+
db,
198+
ComparisonResult {
199+
memory_mb,
200+
latency_us,
201+
recall,
202+
qps,
203+
cost_per_1m_queries,
204+
},
205+
)
178206
})
179-
}).collect();
207+
.collect();
180208

181209
ComparisonReport {
182210
num_vectors,
@@ -210,7 +238,11 @@ pub fn run_comparison_benchmark(config: BenchConfig) -> ComparisonReport {
210238
let mut report = compare_all(config.num_vectors);
211239

212240
// Update Ladybug with real measurements
213-
if let Some((_, result)) = report.results.iter_mut().find(|(db, _)| *db == VectorDB::Ladybug) {
241+
if let Some((_, result)) = report
242+
.results
243+
.iter_mut()
244+
.find(|(db, _)| *db == VectorDB::Ladybug)
245+
{
214246
result.latency_us = ladybug_latency;
215247
result.memory_mb = ladybug_memory as f64 / (1024.0 * 1024.0);
216248
result.qps = 1_000_000.0 / ladybug_latency as f64;
@@ -277,12 +309,16 @@ mod tests {
277309
report.print();
278310

279311
// Ladybug should use less memory than Qdrant
280-
let ladybug_mem = report.results.iter()
312+
let ladybug_mem = report
313+
.results
314+
.iter()
281315
.find(|(db, _)| *db == VectorDB::Ladybug)
282316
.map(|(_, r)| r.memory_mb)
283317
.unwrap();
284318

285-
let qdrant_mem = report.results.iter()
319+
let qdrant_mem = report
320+
.results
321+
.iter()
286322
.find(|(db, _)| *db == VectorDB::Qdrant)
287323
.map(|(_, r)| r.memory_mb)
288324
.unwrap();

‎src/bench/memory.rs‎

Lines changed: 33 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,23 +28,44 @@ impl MemoryReport {
2828
pub fn print(&self) {
2929
println!("\n╔════════════════════════════════════════════════════════════════╗");
3030
println!("║ MEMORY COMPARISON ║");
31-
println!("║ {} vectors ║", format_num(self.num_vectors));
31+
println!(
32+
"║ {} vectors ║",
33+
format_num(self.num_vectors)
34+
);
3235
println!("╠════════════════════════════════════════════════════════════════╣");
3336
println!("║ System │ Total RAM │ Per Vector │ vs Float32 ║");
3437
println!("╠═════════════════╪════════════════╪═══════════════╪════════════╣");
35-
println!("║ Float32 HNSW │ {:>14} │ {:>13} │ 1.0x ║",
36-
format_bytes(self.float32_total), format_bytes(self.float32_per_vec as usize));
37-
println!("║ Float16 HNSW │ {:>14} │ {:>13} │ 1.9x ║",
38-
format_bytes(self.float16_total), format_bytes(self.float16_per_vec as usize));
39-
println!("║ IVF_PQ │ {:>14} │ {:>13} │ 30.0x ║",
40-
format_bytes(self.pq_total), format_bytes(self.pq_per_vec as usize));
41-
println!("║ LADYBUG 10K-bit │ {:>14} │ {:>13} │ {:>8.1}x ║",
42-
format_bytes(self.ladybug_total), format_bytes(self.ladybug_per_vec as usize),
43-
self.savings_vs_f32);
38+
println!(
39+
"║ Float32 HNSW │ {:>14} │ {:>13} │ 1.0x ║",
40+
format_bytes(self.float32_total),
41+
format_bytes(self.float32_per_vec as usize)
42+
);
43+
println!(
44+
"║ Float16 HNSW │ {:>14} │ {:>13} │ 1.9x ║",
45+
format_bytes(self.float16_total),
46+
format_bytes(self.float16_per_vec as usize)
47+
);
48+
println!(
49+
"║ IVF_PQ │ {:>14} │ {:>13} │ 30.0x ║",
50+
format_bytes(self.pq_total),
51+
format_bytes(self.pq_per_vec as usize)
52+
);
53+
println!(
54+
"║ LADYBUG 10K-bit │ {:>14} │ {:>13} │ {:>8.1}x ║",
55+
format_bytes(self.ladybug_total),
56+
format_bytes(self.ladybug_per_vec as usize),
57+
self.savings_vs_f32
58+
);
4459
println!("╚═════════════════╧════════════════╧═══════════════╧════════════╝");
4560
println!();
46-
println!("Ladybug uses {:.1}x LESS RAM than float32 HNSW", self.savings_vs_f32);
47-
println!("Ladybug uses {:.1}x LESS RAM than float16 HNSW", self.savings_vs_f16);
61+
println!(
62+
"Ladybug uses {:.1}x LESS RAM than float32 HNSW",
63+
self.savings_vs_f32
64+
);
65+
println!(
66+
"Ladybug uses {:.1}x LESS RAM than float16 HNSW",
67+
self.savings_vs_f16
68+
);
4869
}
4970
}
5071

0 commit comments

Comments
 (0)