Merge pull request #110 from AdaWorldAPI/claude/cognitive-layer-stack-77KUH

fix: resolve clippy lints for Rust 1.93 CI

Author: AdaWorldAPI

crates/ladybug-contract/src/container.rs

@@ -114,7 +114,7 @@ impl Container {
             return items[0].clone();
         }
         let threshold = items.len() / 2;
-        let even = items.len() % 2 == 0;
+        let even = items.len().is_multiple_of(2);
         let mut result = Container::zero();
         for word in 0..CONTAINER_WORDS {
             let mut out = 0u64;
@@ -236,7 +236,7 @@ impl Container {
     #[inline(always)]
     pub fn view(words: &[u64; CONTAINER_WORDS]) -> &Container {
         debug_assert!(
-            words.as_ptr() as usize % 64 == 0,
+            (words.as_ptr() as usize).is_multiple_of(64),
             "Container::view requires 64-byte aligned input"
         );
         unsafe { &*(words.as_ptr() as *const Container) }
@@ -249,7 +249,7 @@ impl Container {
     #[inline(always)]
     pub fn view_mut(words: &mut [u64; CONTAINER_WORDS]) -> &mut Container {
         debug_assert!(
-            words.as_ptr() as usize % 64 == 0,
+            (words.as_ptr() as usize).is_multiple_of(64),
             "Container::view_mut requires 64-byte aligned input"
         );
         unsafe { &mut *(words.as_mut_ptr() as *mut Container) }

crates/ladybug-contract/src/geometry.rs

@@ -1,11 +1,12 @@
 //! Container geometry — how content containers are interpreted.
 
 /// How the content containers of a [`CogRecord`] are arranged and interpreted.
-#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, Default)]
 #[repr(u8)]
 pub enum ContainerGeometry {
     /// 1 content container: flat 8K CAM fingerprint (default, most common).
     /// Total record: 2 × 1 KB = 2 KB.
+    #[default]
     Cam = 0,
 
     /// 3 content containers: X (what) + Y (where) + Z (how), holographic.
@@ -61,9 +62,3 @@ impl ContainerGeometry {
         }
     }
 }
-
-impl Default for ContainerGeometry {
-    fn default() -> Self {
-        ContainerGeometry::Cam
-    }
-}

crates/ladybug-contract/src/index_types.rs

@@ -129,6 +129,6 @@ pub mod types {
 
     /// Check if a type ID is an edge type.
     pub fn is_edge(t: u16) -> bool {
-        t >= EDGE_START && t <= EDGE_END
+        (EDGE_START..=EDGE_END).contains(&t)
     }
 }

crates/ladybug-contract/src/legacy.rs

@@ -17,22 +17,17 @@ use crate::record::CogRecord;
 // V1 StepStatus
 // ============================================================================
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Default)]
 #[serde(rename_all = "snake_case")]
 pub enum V1StepStatus {
+    #[default]
     Pending,
     Running,
     Completed,
     Failed,
     Skipped,
 }
 
-impl Default for V1StepStatus {
-    fn default() -> Self {
-        Self::Pending
-    }
-}
-
 // ============================================================================
 // V1 UnifiedStep (crewai-rust / n8n-rs schema)
 // ============================================================================
@@ -309,9 +304,7 @@ impl From<&CogRecord> for V1DataEnvelope {
             }
         }
         // Pad L8-L10 with zero (not yet stored in container metadata)
-        for _ in 7..10 {
-            layer_activations.push(0.0);
-        }
+        layer_activations.extend(std::iter::repeat_n(0.0, 3));
 
         V1DataEnvelope {
             data: Value::Null,

crates/ladybug-contract/src/wire.rs

@@ -355,8 +355,8 @@ impl CogPacket {
     /// Get all 10 satisfaction scores as an array.
     pub fn satisfaction_array(&self) -> [f32; 10] {
         let mut scores = [0.0f32; 10];
-        for i in 0..10 {
-            scores[i] = self.satisfaction(i as u8);
+        for (i, score) in scores.iter_mut().enumerate() {
+            *score = self.satisfaction(i as u8);
         }
         scores
     }
@@ -578,7 +578,7 @@ impl CogPacket {
 
         // Determine number of containers from header
         let payload_count = ((header[7] >> 24) & 0xFF) as usize;
-        let payload_count = payload_count.max(1).min(2);
+        let payload_count = payload_count.clamp(1, 2);
         let expected_bytes = HEADER_BYTES + payload_count * CONTAINER_BYTES;
 
         if data.len() < expected_bytes {
@@ -691,7 +691,7 @@ impl CogPacket {
             _ => (0x0Fu8, wire_ops::EXECUTE),
         };
 
-        let source_addr = ((prefix as u16) << 8) | 0x00;
+        let source_addr = (prefix as u16) << 8;
         let target_addr = ((prefix as u16) << 8) | 0x01;
 
         // Content hash expanded to container via SplitMix64

src/cognitive/cognitive_kernel.rs

@@ -30,7 +30,7 @@
 //! └──────────────────────────────────────────────────────────────────────┘
 //! ```
 
-use crate::cognitive::layer_stack::{ConsciousnessSnapshot, LayerId, LayerNode, LayerResult, NUM_LAYERS};
+use crate::cognitive::layer_stack::{ConsciousnessSnapshot, LayerId, LayerResult, NUM_LAYERS};
 use crate::cognitive::metacog::MetaCognition;
 use crate::cognitive::satisfaction_gate::LayerSatisfaction;
 use crate::cognitive::sieve::SocraticSieve;

src/cognitive/sieve.rs

@@ -203,7 +203,7 @@ impl SocraticSieve {
         if sources.is_empty() {
             return TruthValue::unknown();
         }
-        let mut merged = sources[0].clone();
+        let mut merged = sources[0];
         for source in &sources[1..] {
             merged = merged.revision(source);
         }