Commit fcaf4cd
committed
fix(lance_parser): remove #[macro_export] pollution, fix CypherQuery collision
Item 4: Remove #[macro_export] from lance_plan_err!, lance_config_err!,
lance_exec_err! — these are bouncer-internal macros, not crate-level.
Only used in lance_parser/error.rs tests.
Item 5: Replace `pub use ast::*` glob re-export with explicit re-exports
excluding CypherQuery. lance_parser::ast::CypherQuery and cypher.rs::CypherQuery
are different types serving different roles — the glob made them collide
at the query module level. Now the bouncer's CypherQuery stays behind
lance_parser::ast:: and the old cypher.rs CypherQuery owns the unqualified name.
105/105 lance_parser tests pass. 6/6 error tests pass.
https://claude.ai/code/session_018L7tAcJ9ppReFdcjhYjTcb1 parent 3d3ddb0 commit fcaf4cd
2 files changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
83 | 82 | | |
84 | 83 | | |
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
88 | 87 | | |
89 | 88 | | |
90 | | - | |
91 | 89 | | |
92 | 90 | | |
93 | 91 | | |
94 | 92 | | |
95 | 93 | | |
96 | 94 | | |
97 | 95 | | |
98 | | - | |
99 | 96 | | |
100 | 97 | | |
101 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
20 | 28 | | |
21 | 29 | | |
22 | 30 | | |
0 commit comments